From: Thomas Monjalon <thomas@monjalon.net>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org,
John McNamara <john.mcnamara@intel.com>,
Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 3/3] ipc: add warnings about correct API usage
Date: Thu, 09 May 2019 16:59:38 +0200 [thread overview]
Message-ID: <4673364.Vn0jRf8MzI@xps> (raw)
Message-ID: <20190509145938.X6ujCzWqDZ7tR-4IU1g4oKeNhZajDA2cVOIjd99klsE@z> (raw)
In-Reply-To: <d918c51389c904cd568485d82f3fdea7b5da79fc.1556883753.git.anatoly.burakov@intel.com>
03/05/2019 13:50, Anatoly Burakov:
> When handling synchronous or asynchronous requests, the reply
> must be sent explicitly even if the result of the operation is
> an error, to avoid the other side timing out. Make note of this
> in documentation explicitly.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
> --- a/lib/librte_eal/common/include/rte_eal.h
> +++ b/lib/librte_eal/common/include/rte_eal.h
> @@ -226,6 +226,11 @@ struct rte_mp_reply {
> * As we create socket channel for primary/secondary communication, use
> * this function typedef to register action for coming messages.
> *
> + * @note When handling IPC request callbacks, the reply must be sent even in
> + * cases of error handling. Simply retuning success or failure will *not* send
retuning -> returning
Will fix on apply.
next prev parent reply other threads:[~2019-05-09 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 11:50 [dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc Anatoly Burakov
2019-05-03 11:50 ` Anatoly Burakov
2019-05-03 11:50 ` [dpdk-dev] [PATCH 2/3] ipc: add warnings about not using ipc with memory API's Anatoly Burakov
2019-05-03 11:50 ` Anatoly Burakov
2019-05-03 11:50 ` [dpdk-dev] [PATCH 3/3] ipc: add warnings about correct API usage Anatoly Burakov
2019-05-03 11:50 ` Anatoly Burakov
2019-05-09 14:59 ` Thomas Monjalon [this message]
2019-05-09 14:59 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-03 19:03 ` [dpdk-dev] [PATCH 1/3] doc: fix typo in ipc doc Rami Rosen
2019-05-03 19:03 ` Rami Rosen
2019-05-09 14:41 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
2019-05-09 14:41 ` Thomas Monjalon
2019-05-09 15:25 ` [dpdk-dev] " Mcnamara, John
2019-05-09 15:25 ` Mcnamara, John
2019-05-09 15:55 ` Thomas Monjalon
2019-05-09 15:55 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4673364.Vn0jRf8MzI@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).