DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
	Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, dpdk-stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode
Date: Thu, 9 May 2019 19:16:38 +0100	[thread overview]
Message-ID: <b2c00957-f078-b73f-27d4-84c7e4e1ce37@redhat.com> (raw)
Message-ID: <20190509181638.VnIKXnvm3FDYGlnJOweUX23w7YOimwrtWaSIPQ2lKQU@z> (raw)
In-Reply-To: <acc46b64-1707-011d-76ce-7355e3911460@intel.com>

On 09/05/2019 18:50, Ferruh Yigit wrote:
> On 5/9/2019 6:50 PM, Ferruh Yigit wrote:
>> On 4/24/2019 4:26 PM, Anatoly Burakov wrote:
>>> In no-shconf mode, there is no need to clean runtime directory
>>> because it's not created in the first place.
>>>
>>> Fixes: 0a529578f162 ("eal: clean up unused files on initialization")
>>>
>>> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
>>
>> Is this for 18.11.x LTS?
>> cc'ed the stable mail list assuming that is the case.
> 
> +Kevin
> 
>>
>> Is this valid for 19.05 too?
>>

It's already applied on 18.11 branch. The same change is also in master
courtesy of the referenced upstream commit below, so this one not needed
for master. Thanks for checking.

commit 4c1ef6dff7230f08f90427355741f56d2faf5884
Author: Anatoly Burakov <anatoly.burakov@intel.com>
Date:   Wed Apr 24 16:26:10 2019 +0100

    eal: fix cleanup in no-shconf mode

    [ upstream commit 307315d4577462943d0fcb2e6b8c8f35f90698d7 ]

>>> ---
>>>  lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-
>>>  1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c
>>> index 30138b638..59497d04a 100644
>>> --- a/lib/librte_eal/linuxapp/eal/eal.c
>>> +++ b/lib/librte_eal/linuxapp/eal/eal.c
>>> @@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)
>>>  	 * whether we are primary or secondary process, but we cannot remove
>>>  	 * primary process' files because secondary should be able to run even
>>>  	 * if primary process is dead.
>>> +	 *
>>> +	 * In no_shconf mode, no runtime directory is created in the first
>>> +	 * place, so no cleanup needed.
>>>  	 */
>>> -	if (eal_clean_runtime_dir() < 0) {
>>> +	if (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {
>>>  		rte_eal_init_alert("Cannot clear runtime directory\n");
>>>  		return -1;
>>>  	}
>>>
>>
> 


  parent reply	other threads:[~2019-05-09 18:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 15:26 Anatoly Burakov
2019-04-24 15:26 ` Anatoly Burakov
2019-05-09 17:50 ` Ferruh Yigit
2019-05-09 17:50   ` Ferruh Yigit
2019-05-09 17:50   ` Ferruh Yigit
2019-05-09 17:50     ` Ferruh Yigit
2019-05-09 18:16     ` Kevin Traynor [this message]
2019-05-09 18:16       ` Kevin Traynor
2019-05-10 10:53       ` Burakov, Anatoly
2019-05-10 10:53         ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b2c00957-f078-b73f-27d4-84c7e4e1ce37@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).