* [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-03-29 10:22 ` [dpdk-dev] [PATCH v2] " Lukasz Krakowiak
@ 2019-03-29 10:22 ` Lukasz Krakowiak
2019-04-15 15:06 ` Hunt, David
` (2 subsequent siblings)
3 siblings, 0 replies; 18+ messages in thread
From: Lukasz Krakowiak @ 2019-03-29 10:22 UTC (permalink / raw)
To: david.hunt; +Cc: dev, Lukasz Krakowiak
Updated doc for JSON sample code related to vm_power_manager
fifo interface: "command": "destroy", "command": "power".
Corrected typo in doc vm_power_management.rst: 'json' instead
of 'jason'.
---
v2:
* coding style improved
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
---
doc/guides/sample_app_ug/vm_power_management.rst | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
index 14d432e78..0182a92b3 100644
--- a/doc/guides/sample_app_ug/vm_power_management.rst
+++ b/doc/guides/sample_app_ug/vm_power_management.rst
@@ -384,7 +384,7 @@ the file.
The fifo is at /tmp/powermonitor/fifo
-The jason string can be a policy or instruction, and takes the following
+The json string can be a policy or instruction, and takes the following
format:
.. code-block:: javascript
@@ -597,7 +597,7 @@ Profile destroy example:
.. code-block:: javascript
- {"profile": {
+ {"policy": {
"name": "ubuntu",
"command": "destroy",
}}
@@ -606,8 +606,9 @@ Power command example:
.. code-block:: javascript
- {"command": {
+ {"instruction": {
"name": "ubuntu",
+ "command": "power",
"unit": "SCALE_MAX",
"resource_id": 10
}}
--
2.19.2.windows.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-03-29 10:22 ` [dpdk-dev] [PATCH v2] " Lukasz Krakowiak
2019-03-29 10:22 ` Lukasz Krakowiak
@ 2019-04-15 15:06 ` Hunt, David
2019-04-15 15:06 ` Hunt, David
2019-04-22 22:30 ` Thomas Monjalon
2019-05-13 9:04 ` [dpdk-dev] [PATCH v3] " David Hunt
3 siblings, 1 reply; 18+ messages in thread
From: Hunt, David @ 2019-04-15 15:06 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
On 29/3/2019 10:22 AM, Lukasz Krakowiak wrote:
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
> Corrected typo in doc vm_power_management.rst: 'json' instead
> of 'jason'.
>
> ---
> v2:
> * coding style improved
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> doc/guides/sample_app_ug/vm_power_management.rst | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
> index 14d432e78..0182a92b3 100644
> --- a/doc/guides/sample_app_ug/vm_power_management.rst
> +++ b/doc/guides/sample_app_ug/vm_power_management.rst
> @@ -384,7 +384,7 @@ the file.
>
> The fifo is at /tmp/powermonitor/fifo
>
> -The jason string can be a policy or instruction, and takes the following
> +The json string can be a policy or instruction, and takes the following
> format:
>
> .. code-block:: javascript
> @@ -597,7 +597,7 @@ Profile destroy example:
>
> .. code-block:: javascript
>
> - {"profile": {
> + {"policy": {
> "name": "ubuntu",
> "command": "destroy",
> }}
> @@ -606,8 +606,9 @@ Power command example:
>
> .. code-block:: javascript
>
> - {"command": {
> + {"instruction": {
> "name": "ubuntu",
> + "command": "power",
> "unit": "SCALE_MAX",
> "resource_id": 10
> }}
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-04-15 15:06 ` Hunt, David
@ 2019-04-15 15:06 ` Hunt, David
0 siblings, 0 replies; 18+ messages in thread
From: Hunt, David @ 2019-04-15 15:06 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev
On 29/3/2019 10:22 AM, Lukasz Krakowiak wrote:
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
> Corrected typo in doc vm_power_management.rst: 'json' instead
> of 'jason'.
>
> ---
> v2:
> * coding style improved
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> ---
> doc/guides/sample_app_ug/vm_power_management.rst | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
> index 14d432e78..0182a92b3 100644
> --- a/doc/guides/sample_app_ug/vm_power_management.rst
> +++ b/doc/guides/sample_app_ug/vm_power_management.rst
> @@ -384,7 +384,7 @@ the file.
>
> The fifo is at /tmp/powermonitor/fifo
>
> -The jason string can be a policy or instruction, and takes the following
> +The json string can be a policy or instruction, and takes the following
> format:
>
> .. code-block:: javascript
> @@ -597,7 +597,7 @@ Profile destroy example:
>
> .. code-block:: javascript
>
> - {"profile": {
> + {"policy": {
> "name": "ubuntu",
> "command": "destroy",
> }}
> @@ -606,8 +606,9 @@ Power command example:
>
> .. code-block:: javascript
>
> - {"command": {
> + {"instruction": {
> "name": "ubuntu",
> + "command": "power",
> "unit": "SCALE_MAX",
> "resource_id": 10
> }}
Acked-by: David Hunt <david.hunt@intel.com>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-03-29 10:22 ` [dpdk-dev] [PATCH v2] " Lukasz Krakowiak
2019-03-29 10:22 ` Lukasz Krakowiak
2019-04-15 15:06 ` Hunt, David
@ 2019-04-22 22:30 ` Thomas Monjalon
2019-04-22 22:30 ` Thomas Monjalon
2019-05-09 18:57 ` Thomas Monjalon
2019-05-13 9:04 ` [dpdk-dev] [PATCH v3] " David Hunt
3 siblings, 2 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-04-22 22:30 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev, david.hunt
29/03/2019 11:22, Lukasz Krakowiak:
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
> Corrected typo in doc vm_power_management.rst: 'json' instead
> of 'jason'.
>
> ---
> v2:
> * coding style improved
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
The SoB must be above the ---
Please add a line "Fixes:"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-04-22 22:30 ` Thomas Monjalon
@ 2019-04-22 22:30 ` Thomas Monjalon
2019-05-09 18:57 ` Thomas Monjalon
1 sibling, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-04-22 22:30 UTC (permalink / raw)
To: Lukasz Krakowiak; +Cc: dev, david.hunt
29/03/2019 11:22, Lukasz Krakowiak:
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
> Corrected typo in doc vm_power_management.rst: 'json' instead
> of 'jason'.
>
> ---
> v2:
> * coding style improved
>
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
The SoB must be above the ---
Please add a line "Fixes:"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-04-22 22:30 ` Thomas Monjalon
2019-04-22 22:30 ` Thomas Monjalon
@ 2019-05-09 18:57 ` Thomas Monjalon
2019-05-09 18:57 ` Thomas Monjalon
1 sibling, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-09 18:57 UTC (permalink / raw)
To: Lukasz Krakowiak, david.hunt; +Cc: dev
23/04/2019 00:30, Thomas Monjalon:
> 29/03/2019 11:22, Lukasz Krakowiak:
> > Updated doc for JSON sample code related to vm_power_manager
> > fifo interface: "command": "destroy", "command": "power".
> > Corrected typo in doc vm_power_management.rst: 'json' instead
> > of 'jason'.
> >
> > ---
> > v2:
> > * coding style improved
> >
> > Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> The SoB must be above the ---
> Please add a line "Fixes:"
Why there is no update?
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v2] doc: updated json sample code for fifo interface
2019-05-09 18:57 ` Thomas Monjalon
@ 2019-05-09 18:57 ` Thomas Monjalon
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-09 18:57 UTC (permalink / raw)
To: Lukasz Krakowiak, david.hunt; +Cc: dev
23/04/2019 00:30, Thomas Monjalon:
> 29/03/2019 11:22, Lukasz Krakowiak:
> > Updated doc for JSON sample code related to vm_power_manager
> > fifo interface: "command": "destroy", "command": "power".
> > Corrected typo in doc vm_power_management.rst: 'json' instead
> > of 'jason'.
> >
> > ---
> > v2:
> > * coding style improved
> >
> > Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> The SoB must be above the ---
> Please add a line "Fixes:"
Why there is no update?
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v3] doc: updated json sample code for fifo interface
2019-03-29 10:22 ` [dpdk-dev] [PATCH v2] " Lukasz Krakowiak
` (2 preceding siblings ...)
2019-04-22 22:30 ` Thomas Monjalon
@ 2019-05-13 9:04 ` David Hunt
2019-05-13 9:04 ` David Hunt
` (2 more replies)
3 siblings, 3 replies; 18+ messages in thread
From: David Hunt @ 2019-05-13 9:04 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Lukasz Krakowiak
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Updated doc for JSON sample code related to vm_power_manager
fifo interface: "command": "destroy", "command": "power".
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
v2:
* coding style improved
v3:
* move Signed-off-by: to correct location in patch file.
* rebase to master
---
doc/guides/sample_app_ug/vm_power_management.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
index 109d10957..5d9a26172 100644
--- a/doc/guides/sample_app_ug/vm_power_management.rst
+++ b/doc/guides/sample_app_ug/vm_power_management.rst
@@ -597,7 +597,7 @@ Profile destroy example:
.. code-block:: javascript
- {"profile": {
+ {"policy": {
"name": "ubuntu",
"command": "destroy",
}}
@@ -606,8 +606,9 @@ Power command example:
.. code-block:: javascript
- {"command": {
+ {"instruction": {
"name": "ubuntu",
+ "command": "power",
"unit": "SCALE_MAX",
"resource_id": 10
}}
--
2.17.1
^ permalink raw reply [flat|nested] 18+ messages in thread* [dpdk-dev] [PATCH v3] doc: updated json sample code for fifo interface
2019-05-13 9:04 ` [dpdk-dev] [PATCH v3] " David Hunt
@ 2019-05-13 9:04 ` David Hunt
2019-05-13 13:49 ` Thomas Monjalon
2019-05-13 14:13 ` [dpdk-dev] [PATCH v4] " David Hunt
2 siblings, 0 replies; 18+ messages in thread
From: David Hunt @ 2019-05-13 9:04 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Lukasz Krakowiak
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Updated doc for JSON sample code related to vm_power_manager
fifo interface: "command": "destroy", "command": "power".
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
v2:
* coding style improved
v3:
* move Signed-off-by: to correct location in patch file.
* rebase to master
---
doc/guides/sample_app_ug/vm_power_management.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
index 109d10957..5d9a26172 100644
--- a/doc/guides/sample_app_ug/vm_power_management.rst
+++ b/doc/guides/sample_app_ug/vm_power_management.rst
@@ -597,7 +597,7 @@ Profile destroy example:
.. code-block:: javascript
- {"profile": {
+ {"policy": {
"name": "ubuntu",
"command": "destroy",
}}
@@ -606,8 +606,9 @@ Power command example:
.. code-block:: javascript
- {"command": {
+ {"instruction": {
"name": "ubuntu",
+ "command": "power",
"unit": "SCALE_MAX",
"resource_id": 10
}}
--
2.17.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH v3] doc: updated json sample code for fifo interface
2019-05-13 9:04 ` [dpdk-dev] [PATCH v3] " David Hunt
2019-05-13 9:04 ` David Hunt
@ 2019-05-13 13:49 ` Thomas Monjalon
2019-05-13 13:49 ` Thomas Monjalon
2019-05-13 14:13 ` [dpdk-dev] [PATCH v4] " David Hunt
2 siblings, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 13:49 UTC (permalink / raw)
To: David Hunt; +Cc: dev, Lukasz Krakowiak
13/05/2019 11:04, David Hunt:
> From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
There is no explanation about why this change is required.
Was there some changes in the code?
If yes, please provide Fixes: reference so we can know where to backport.
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [dpdk-dev] [PATCH v3] doc: updated json sample code for fifo interface
2019-05-13 13:49 ` Thomas Monjalon
@ 2019-05-13 13:49 ` Thomas Monjalon
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 13:49 UTC (permalink / raw)
To: David Hunt; +Cc: dev, Lukasz Krakowiak
13/05/2019 11:04, David Hunt:
> From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
There is no explanation about why this change is required.
Was there some changes in the code?
If yes, please provide Fixes: reference so we can know where to backport.
^ permalink raw reply [flat|nested] 18+ messages in thread
* [dpdk-dev] [PATCH v4] doc: updated json sample code for fifo interface
2019-05-13 9:04 ` [dpdk-dev] [PATCH v3] " David Hunt
2019-05-13 9:04 ` David Hunt
2019-05-13 13:49 ` Thomas Monjalon
@ 2019-05-13 14:13 ` David Hunt
2019-05-13 14:13 ` David Hunt
2019-05-13 16:57 ` Thomas Monjalon
2 siblings, 2 replies; 18+ messages in thread
From: David Hunt @ 2019-05-13 14:13 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Lukasz Krakowiak, stable
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Updated doc for JSON sample code related to vm_power_manager
fifo interface: "command": "destroy", "command": "power".
There is no code change to go with this doc update, it is to fix
the docs to match the implementation in the code.
Fixes: a63504a90f ("examples/power: add JSON string handling")
Cc: stable@dpdk.org
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/sample_app_ug/vm_power_management.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
index 109d10957..5d9a26172 100644
--- a/doc/guides/sample_app_ug/vm_power_management.rst
+++ b/doc/guides/sample_app_ug/vm_power_management.rst
@@ -597,7 +597,7 @@ Profile destroy example:
.. code-block:: javascript
- {"profile": {
+ {"policy": {
"name": "ubuntu",
"command": "destroy",
}}
@@ -606,8 +606,9 @@ Power command example:
.. code-block:: javascript
- {"command": {
+ {"instruction": {
"name": "ubuntu",
+ "command": "power",
"unit": "SCALE_MAX",
"resource_id": 10
}}
--
2.17.1
^ permalink raw reply [flat|nested] 18+ messages in thread* [dpdk-dev] [PATCH v4] doc: updated json sample code for fifo interface
2019-05-13 14:13 ` [dpdk-dev] [PATCH v4] " David Hunt
@ 2019-05-13 14:13 ` David Hunt
2019-05-13 16:57 ` Thomas Monjalon
1 sibling, 0 replies; 18+ messages in thread
From: David Hunt @ 2019-05-13 14:13 UTC (permalink / raw)
To: dev; +Cc: david.hunt, Lukasz Krakowiak, stable
From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Updated doc for JSON sample code related to vm_power_manager
fifo interface: "command": "destroy", "command": "power".
There is no code change to go with this doc update, it is to fix
the docs to match the implementation in the code.
Fixes: a63504a90f ("examples/power: add JSON string handling")
Cc: stable@dpdk.org
Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
doc/guides/sample_app_ug/vm_power_management.rst | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/doc/guides/sample_app_ug/vm_power_management.rst b/doc/guides/sample_app_ug/vm_power_management.rst
index 109d10957..5d9a26172 100644
--- a/doc/guides/sample_app_ug/vm_power_management.rst
+++ b/doc/guides/sample_app_ug/vm_power_management.rst
@@ -597,7 +597,7 @@ Profile destroy example:
.. code-block:: javascript
- {"profile": {
+ {"policy": {
"name": "ubuntu",
"command": "destroy",
}}
@@ -606,8 +606,9 @@ Power command example:
.. code-block:: javascript
- {"command": {
+ {"instruction": {
"name": "ubuntu",
+ "command": "power",
"unit": "SCALE_MAX",
"resource_id": 10
}}
--
2.17.1
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH v4] doc: updated json sample code for fifo interface
2019-05-13 14:13 ` [dpdk-dev] [PATCH v4] " David Hunt
2019-05-13 14:13 ` David Hunt
@ 2019-05-13 16:57 ` Thomas Monjalon
2019-05-13 16:57 ` Thomas Monjalon
1 sibling, 1 reply; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 16:57 UTC (permalink / raw)
To: David Hunt, Lukasz Krakowiak; +Cc: dev, stable
13/05/2019 16:13, David Hunt:
> From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
>
> There is no code change to go with this doc update, it is to fix
> the docs to match the implementation in the code.
>
> Fixes: a63504a90f ("examples/power: add JSON string handling")
> Cc: stable@dpdk.org
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 18+ messages in thread* Re: [dpdk-dev] [PATCH v4] doc: updated json sample code for fifo interface
2019-05-13 16:57 ` Thomas Monjalon
@ 2019-05-13 16:57 ` Thomas Monjalon
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Monjalon @ 2019-05-13 16:57 UTC (permalink / raw)
To: David Hunt, Lukasz Krakowiak; +Cc: dev, stable
13/05/2019 16:13, David Hunt:
> From: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
>
> Updated doc for JSON sample code related to vm_power_manager
> fifo interface: "command": "destroy", "command": "power".
>
> There is no code change to go with this doc update, it is to fix
> the docs to match the implementation in the code.
>
> Fixes: a63504a90f ("examples/power: add JSON string handling")
> Cc: stable@dpdk.org
> Signed-off-by: Lukasz Krakowiak <lukaszx.krakowiak@intel.com>
> Acked-by: David Hunt <david.hunt@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 18+ messages in thread