Re: [dpdk-dev] [PATCH v2] eventdev: fix Rx adapter event flush logic

["Mattias Rönnblom" <mattias.ronnblom@ericsson.com>]

On 2019-05-09 21:17, Thomas Monjalon wrote:
> 09/05/2019 06:50, Nikhil Rao:
>> The Rx adapter flushes events only if it has BATCH_SIZE
>> events buffered where BATCH_SIZE is set to 32, e.g., if a
>> single packet is sent, it is never passed to
>> eventdev. Fix this issue by adding an event buffer flush
>> either when a Rx queue is found to be empty or the adapter service
>> function has processed the max number of packets for an invocation.
>>
>> Bugzilla ID: 277
>>
>> Fixes: 6b83f5935543 ("eventdev: add event buffer flush in Rx adapter")
>>
>> Reported-by: Matias Elo <matias.elo@nokia.com>
>>
>> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
>> ---
>> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
>> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
>> @@ -872,7 +872,7 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
>> -	if (buf->count >= BATCH_SIZE)
>> +	if (buf->count)
> 
> I don't this code, but it looks you are removing a test
> which was probably done on purpose.
> By the way, you should make your test explicit with "!= 0".
> 

"> 0". count is unsigned.