From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 36B49A0096 for ; Thu, 9 May 2019 22:36:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0630F493D; Thu, 9 May 2019 22:36:05 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id D2CD62C18 for ; Thu, 9 May 2019 22:36:03 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 78FE42073F; Thu, 9 May 2019 16:36:03 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 09 May 2019 16:36:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iO+XDLvtSKxIdxyW0xkT3Go9iaLV3W7SNBpnvpvUu9M=; b=L+Di4bozMCUt kzxPjdImIKdSfIFKm00kuAb0lWVcJcLvQ9XTtlZXodtc6yrPWMLovD7JKwVxACvr Dip5tJ+qyJqf3BwerIpvcKTbAVbXdWdUlUSavVLES/M/ZheJNdiDA2yMO0mDv4uC cjASWVwaGjwExwTLy/8u2FYS804cg2E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=iO+XDLvtSKxIdxyW0xkT3Go9iaLV3W7SNBpnvpvUu 9M=; b=7cal+2xvoB6uwmUqT1I5JVtUlpmgj8PqiNf5lqV6wbOxtupFSDeTtGyxF 0+OxVoShKPISgIrfaHo7mc5riShmdWNcKhBl4PRVrmIpqzvu42LJ9yheP4oI/Yli n/qxF6hgBoG4QJ9xrk7Wq1VYFseyqZ5KakHnOXT9NH781cBAsMWq5daFLEyxJJco sQZkrq2xM+zUONqxNciPTGr5s7fTvkuPCzGbm0iY0tzikB80+8OgB9HtfeW4FTRC cDYpvFaPgjiPBrMD2Iz1WFydnxwA5on5AFmv18wA0sfFXAtBG+G0P8Cj2/sJZip/ TnZqc510f5dzq2fAVq9aKz0B+VkUQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeeigdeltdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EA5FA80065; Thu, 9 May 2019 16:36:01 -0400 (EDT) From: Thomas Monjalon To: Dharmik Thakkar Cc: dev@dpdk.org, "Wang, Yipeng1" , "Gobriel, Sameh" , "honnappa.nagarahalli@arm.com" , "zhongdahulinfan@163.com" Date: Thu, 09 May 2019 22:36:00 +0200 Message-ID: <1586488.L0gfE9as30@xps> In-Reply-To: References: <20190509133924.7153-1-dharmik.thakkar@arm.com> <2469312.dFCSdvozyX@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 0/3] hash: fix bugs in 'free key with position' X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509203600.dVkp89V_hkGpmst0ALBjk4ODiAO99uPABXFYKTFGfME@z> 09/05/2019 21:36, Wang, Yipeng1: > From: Thomas Monjalon [mailto:thomas@monjalon.net] > >09/05/2019 19:19, Dharmik Thakkar: > >> This patch series solves 2 bugs reported on Bugzilla (bug-261) within > >> the function rte_hash_free_key_with_postion(). It also adds a test case > >> to catch similar bugs in the future. > >> > >> https://bugs.dpdk.org/show_bug.cgi?id=261 > > > >Yipeng, Sameh, should it enter in 19.05-rc4? > >Are you sure it does not break things more? > >If yes, please give your ack. > [Wang, Yipeng] > Please go ahead Thomas, I reviewed the code and it will not break other things. The > changes are refrained inside an experimental API function. > > I haven't done the meson build test though. Applied, thanks