From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D4C7AA0096
for <public@inbox.dpdk.org>; Fri, 10 May 2019 11:47:49 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CF75F5681;
Fri, 10 May 2019 11:47:48 +0200 (CEST)
Received: from sesbmg22.ericsson.net (sesbmg22.ericsson.net [193.180.251.48])
by dpdk.org (Postfix) with ESMTP id D4E254D27
for <dev@dpdk.org>; Fri, 10 May 2019 11:47:47 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801;
c=relaxed/relaxed;
q=dns/txt; i=@ericsson.com; t=1557481667; x=1560073667;
h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type:
Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From:
Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id:
List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
bh=w1hIENUNtJDAT2UBaw4GrBe7PF6xYudtvABRk2lr+W8=;
b=HC75e9hU6oRIZ/yl6nZQyG3G0BJ6SfgKbxJar3ZuiwL5MpyqvbnzdVJhYGf6xCb9
UXkO/Je80tEvelujt0xL197f2l1dfRyHDzKBcPk5pc4Ez+vqbG/1vk/s0iWikb6i
Q9KYoKIvEhDS1DpUjG4CvPvVOkEbt+x9trb7i9F1iqI=;
X-AuditID: c1b4fb30-6f5ff70000001814-cf-5cd548c33e01
Received: from ESESBMB502.ericsson.se (Unknown_Domain [153.88.183.115])
by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id
1B.78.06164.3C845DC5; Fri, 10 May 2019 11:47:47 +0200 (CEST)
Received: from ESESSMR506.ericsson.se (153.88.183.128) by
ESESBMB502.ericsson.se (153.88.183.185) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
15.1.1713.5; Fri, 10 May 2019 11:47:47 +0200
Received: from ESESBMB502.ericsson.se (153.88.183.169) by
ESESSMR506.ericsson.se (153.88.183.128) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id
15.1.1713.5; Fri, 10 May 2019 11:47:46 +0200
Received: from selio1a020.lmera.ericsson.se (153.88.183.153) by
smtp.internal.ericsson.com (153.88.183.185) with Microsoft SMTP Server id
15.1.1713.5 via Frontend Transport; Fri, 10 May 2019 11:47:46 +0200
Received: from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se
[150.132.109.241])
by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id
x4A9lk1e008431; Fri, 10 May 2019 11:47:46 +0200 (CEST)
From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>
To: <dev@dpdk.org>
CC: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
<stefan.sundkvist@ericsson.com>, =?UTF-8?q?Mattias=20R=C3=B6nnblom?=
<mattias.ronnblom@ericsson.com>
Date: Fri, 10 May 2019 11:47:23 +0200
Message-ID: <20190510094723.3627-1-mattias.ronnblom@ericsson.com>
X-Mailer: git-send-email 2.17.1
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrELMWRmVeSWpSXmKPExsUyM2J7se5hj6sxBmduiVm8+7SdyWLiJBMH
Jo8NJ/pZPX4tWMoawBTFZZOSmpNZllqkb5fAlXF94WK2grvcFbt2f2VpYHzE2cXIySEhYCLx
ceURli5GLg4hgaOMEpOaf7BDON8YJdbcX8MG52y4sJQFpEVI4CKjxOTLShCJy4wS53+tAEuw
CXhKTH7XDWaLCAhJLP14mR3EZhaYxSjx9bkyiC0MVDPn2zZWEJtFQFWi8+xpZhCbV8BR4nXf
ZUaIm+QlVm84ABUXlDg58wkLxBxNidbtv6Fmyks0b53NDHGQlsT9JV+YJzAKzkLSMgtJyywk
LQsYmVcxihanFiflphsZ6aUWZSYXF+fn6eWllmxiBIbswS2/DXYwvnzueIhRgINRiYc3yfpq
jBBrYllxZe4hRgkOZiUR3iKdKzFCvCmJlVWpRfnxRaU5qcWHGKU5WJTEeaNX74kREkhPLEnN
Tk0tSC2CyTJxcEo1MJb/WCV7ZF1mkeSEm/vO8EZHO25LZ4qb/z7Rj/nR0iPzf8Rus56v8mf/
pERPD5ZLlub/l5iXHLpvd/X3QQ4jEYuLrTqZ8x/Mrbr+9/chg4pOLmBczRa/oV02IVfrcMrD
1TazDjOcmtbS/2f/5X29il+DXaZuXSsgx3PjyYQO7tZfsV+WP/5em6PEUpyRaKjFXFScCAAd
jciyVQIAAA==
Subject: [dpdk-dev] [PATCH] event/dsw: ignore scheduling type for
single-link queues
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190510094723.CDXhgaN02dZfB_jUuReMFDChJ--S-yhDRf90lgI8rIc@z>
The scheduling type parameter is not applicable for single link
queues. DSW would, at the time of rte_event_queue_setup(), erroneously
verify that scheduling type was one of the supported types, and
returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED.
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
drivers/event/dsw/dsw_evdev.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c
index 4157d130c..9387d4149 100644
--- a/drivers/event/dsw/dsw_evdev.c
+++ b/drivers/event/dsw/dsw_evdev.c
@@ -102,9 +102,6 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
if (RTE_EVENT_QUEUE_CFG_ALL_TYPES & conf->event_queue_cfg)
return -ENOTSUP;
- if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
- return -ENOTSUP;
-
/* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it
* avoid the "fake" TYPE_PARALLEL flow_id assignment. Since
* the queue will only have a single serving port, no
@@ -113,8 +110,12 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id,
*/
if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg)
queue->schedule_type = RTE_SCHED_TYPE_ATOMIC;
- else /* atomic or parallel */
+ else {
+ if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED)
+ return -ENOTSUP;
+ /* atomic or parallel */
queue->schedule_type = conf->schedule_type;
+ }
queue->num_serving_ports = 0;
--
2.17.1