From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B588BA0096 for ; Fri, 10 May 2019 14:18:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BE6275398; Fri, 10 May 2019 14:18:20 +0200 (CEST) Received: from sesbmg23.ericsson.net (sesbmg23.ericsson.net [193.180.251.37]) by dpdk.org (Postfix) with ESMTP id 226B34CA7 for ; Fri, 10 May 2019 14:18:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; d=ericsson.com; s=mailgw201801; c=relaxed/relaxed; q=dns/txt; i=@ericsson.com; t=1557490698; x=1560082698; h=From:Sender:Reply-To:Subject:Date:Message-ID:To:CC:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=AUtg15KnAy1R603jdaF/GetMTCs5BIBGeDwMh+3nmu0=; b=VkaWzvUG8z0XPOmEdIUNZjraPSxK2BMZFnVlVargWDT0CEAb8QNO+sNSwsh4x+sE 9azhwOsrc0mxkqYmcIMBHHo/jpGCBIjDgj4NvoiuhhFHIDdhXK2U2jEQeZJHtcvU JNVGt8Fwz+MkSMoU2w44HWxlIVOf2SSWx6bl8Vcc4HQ=; X-AuditID: c1b4fb25-3b1ff700000029f0-21-5cd56c0aef85 Received: from ESESSMB501.ericsson.se (Unknown_Domain [153.88.183.119]) by sesbmg23.ericsson.net (Symantec Mail Security) with SMTP id 7D.96.10736.A0C65DC5; Fri, 10 May 2019 14:18:18 +0200 (CEST) Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Fri, 10 May 2019 14:18:18 +0200 Received: from selio1a020.lmera.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.191) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Fri, 10 May 2019 14:18:18 +0200 Received: from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se [150.132.109.241]) by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id x4ACIIa3016765; Fri, 10 May 2019 14:18:18 +0200 (CEST) From: =?UTF-8?q?Mattias=20R=C3=B6nnblom?= To: CC: Jerin Jacob , , , =?UTF-8?q?Mattias=20R=C3=B6nnblom?= Date: Fri, 10 May 2019 14:18:16 +0200 Message-ID: <20190510121816.6844-1-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <5057d39b-ade8-c66b-7f21-91230673e184@redhat.com> References: <5057d39b-ade8-c66b-7f21-91230673e184@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrILMWRmVeSWpSXmKPExsUyM2J7uS5XztUYg9XftSzefdrOZDFxkonF v44/7A7MHhtO9LN6/FqwlDWAKYrLJiU1J7MstUjfLoErY8qxA0wFO3kqDi54yNLAuIGri5GD Q0LARGLVBqMuRi4OIYGjjBI/5u1lg3C+MUpsP3eYCcK5yChxpu0OaxcjJ5BzmVHi8BlZEJtN wFNi8rtuFhBbREBIYunHy+wgDcwCaxklOu+sZwNZISzgI9H/VR+khkVAVWLPrgdsIDavgKPE vWu9zCC2hIC8xOoNB8BsTgE7iZWb37NB7LKVONE+jR2iXlDi5MwnYLuYBTQlWrf/Zoew5SWa t85mhqjXkri/5AvzBEahWUhaZiFpmYWkZQEj8ypG0eLU4qTcdCNjvdSizOTi4vw8vbzUkk2M wIA+uOW36g7Gy28cDzEKcDAq8fB6RlyNEWJNLCuuzD3EKMHBrCTCW6RzJUaINyWxsiq1KD++ qDQntfgQozQHi5I4b/TqPTFCAumJJanZqakFqUUwWSYOTqkGRqWYzNfPjJbn6xzlD81W9e4X OfpGSN5EkoMtj3OZ+ox91/edn8KUbPL+YdnCJUF/Ft5XSVijcPP07eaJ+SZGC3T7Hmcbt290 mXooTnvS042mL6KSywMeByWtFGKoulLX2n5d8+EC+QkMd83S+r8XHViRyTb9ShpPyRHre805 cVVT/puuPxQYpsRSnJFoqMVcVJwIAAbTGbtkAgAA Subject: [dpdk-dev] [PATCH v2] event/dsw: ignore scheduling type for single-link queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510121816.DRZjxA0JfJdDC4C0L97-O8Zu27CZW8Hkvtt7SF4U1Xo@z> The scheduling type parameter is not applicable for single link queues. DSW would, at the time of rte_event_queue_setup(), erroneously verify that scheduling type was one of the supported types, and returned -ENOTSUP in case of RTE_SCHED_TYPE_ORDERED. Fixes: 4540ee9c68 ("event/dsw: add device and queue configuration") Cc: stable@dpdk.org Signed-off-by: Mattias Rönnblom --- drivers/event/dsw/dsw_evdev.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.c index 4157d130c..9387d4149 100644 --- a/drivers/event/dsw/dsw_evdev.c +++ b/drivers/event/dsw/dsw_evdev.c @@ -102,9 +102,6 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, if (RTE_EVENT_QUEUE_CFG_ALL_TYPES & conf->event_queue_cfg) return -ENOTSUP; - if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED) - return -ENOTSUP; - /* SINGLE_LINK is better off treated as TYPE_ATOMIC, since it * avoid the "fake" TYPE_PARALLEL flow_id assignment. Since * the queue will only have a single serving port, no @@ -113,8 +110,12 @@ dsw_queue_setup(struct rte_eventdev *dev, uint8_t queue_id, */ if (RTE_EVENT_QUEUE_CFG_SINGLE_LINK & conf->event_queue_cfg) queue->schedule_type = RTE_SCHED_TYPE_ATOMIC; - else /* atomic or parallel */ + else { + if (conf->schedule_type == RTE_SCHED_TYPE_ORDERED) + return -ENOTSUP; + /* atomic or parallel */ queue->schedule_type = conf->schedule_type; + } queue->num_serving_ports = 0; -- 2.17.1