From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id C8BF4A0096
for <public@inbox.dpdk.org>; Fri, 10 May 2019 15:30:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 36290559A;
Fri, 10 May 2019 15:30:57 +0200 (CEST)
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
[66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A92954CC7;
Fri, 10 May 2019 15:30:55 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
by mailout.nyi.internal (Postfix) with ESMTP id 17CA7239AC;
Fri, 10 May 2019 09:30:54 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
by compute1.internal (MEProxy); Fri, 10 May 2019 09:30:54 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
from:to:cc:subject:date:message-id:in-reply-to:references
:mime-version:content-transfer-encoding:content-type; s=mesmtp;
bh=bY+UZ7fV80tDtV8GAmdXJZ4bYIJUx+meGkYDp7i4xsY=; b=rl6vLPoaMhhg
7WZWEU1Pm/az3w4veweEwkDUu7tFb+hU1OaJkZCUp1p+GbzjnRJpr1kcRM9TZwGC
esKtGqomNO4DHgAE/F4m2kfWemZHldCiJ28uidB/eTzxz/SQozHuw1svEc3SUC/c
swfv/uDC7N5A3tgLTpGchA+QtubvBBQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:content-transfer-encoding:content-type
:date:from:in-reply-to:message-id:mime-version:references
:subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
:x-sasl-enc; s=fm2; bh=bY+UZ7fV80tDtV8GAmdXJZ4bYIJUx+meGkYDp7i4x
sY=; b=XoKBPJj0MgpeEd3eNJqlFz8aoRHI6SAepsz9xVl770VEPgEvKY4okY7o5
DyWG1A+U1I0/QP+2r8QZ2unUIDpsku/4V77sI/8mR/ZENK3CAwaU9ojqQXNowha6
ag0bMutyyrvsZMwRx14e5J7oNH3gWgA2wqxp1grpRNN3o/dcfs6vY20figs21BTq
iY4KBSjkq6ToxE8/9jdWJd6CAKpqYqsMNEOrVvT9Q8699W+MRgT6sZIWk1IdOcRJ
K5q8UtHWwimVbIZDlhsB2sze8kQMVz+p9p1TJJF5GISlOr7npuXH6VF6ZHSlwGQ/
j4OFRo+bzO1OsVd0BXY/+76LYPOfQ==
X-ME-Sender: <xms:DX3VXP8mWLPwxPkmLSm8tDG7ami1TE8OLx5K1UX78BlrE3r9OITiYA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeekgdeijecutefuodetggdotefrodftvf
curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph
epledtrdehtddrudegledrvdduieenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhm
rghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt
X-ME-Proxy: <xmx:DX3VXLARGCUPJhnjTu4hselrSI9igb92WrBujLvsu0LrZ1ox71yDcQ>
<xmx:DX3VXAjyGBNe2OkYvfkIMDj3gama2ONwkJoSVHoD1DWb4r8018bFLg>
<xmx:DX3VXDMrjYAhoZAsj_lYFXff90uhpiqgAijC0_FXgjtVfMZSNxJC1g>
<xmx:Dn3VXEiTcS5rVUpB3Q-x6k-59heuFzXUEYGwooLUZytENrnm5udb4g>
Received: from xps.localnet (lfbn-bor-1-57-216.w90-50.abo.wanadoo.fr
[90.50.149.216])
by mail.messagingengine.com (Postfix) with ESMTPA id 6C3398005A;
Fri, 10 May 2019 09:30:52 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, jerinj@marvell.com,
matias.elo@nokia.com
Date: Fri, 10 May 2019 15:30:49 +0200
Message-ID: <33880117.az6yai42PP@xps>
In-Reply-To: <1557475690-42133-1-git-send-email-nikhil.rao@intel.com>
References: <1557376797-10609-1-git-send-email-nikhil.rao@intel.com>
<1557475690-42133-1-git-send-email-nikhil.rao@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v3] eventdev: fix Rx adapter
event flush logic
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Message-ID: <20190510133049.0oztPRE9iOeUibgFluYKjbySK6NVoPjli0Eljqoa0FM@z>
Any review please?
10/05/2019 10:08, Nikhil Rao:
> The Rx adapter flushes events only if it has BATCH_SIZE
> events buffered where BATCH_SIZE is set to 32, e.g., if a
> single packet is sent, it is never passed to
> eventdev. Fix this issue by adding an event buffer flush
> either when a Rx queue is found to be empty or the adapter service
> function has processed the max number of packets for an invocation.
>
> Bugzilla ID: 277
>
> Fixes: 6b83f5935543 ("eventdev: add event buffer flush in Rx adapter")
>
> Reported-by: Matias Elo <matias.elo@nokia.com>
>
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
> lib/librte_eventdev/rte_event_eth_rx_adapter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> v2:
> * add Bugzilla ID
>
> v3:
> * add stable CC
> * replace boolean check with check for > 0
>
> diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> index 8b6e69d..b60674b 100644
> --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c
> @@ -872,7 +872,7 @@ static uint16_t rxa_gcd_u16(uint16_t a, uint16_t b)
> break;
> }
>
> - if (buf->count >= BATCH_SIZE)
> + if (buf->count > 0)
> rxa_flush_event_buffer(rx_adapter);
>
> return nb_rx;
>