From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00DC5A0096 for ; Fri, 10 May 2019 15:44:26 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C81134F93; Fri, 10 May 2019 15:44:26 +0200 (CEST) Received: from mail-vk1-f193.google.com (mail-vk1-f193.google.com [209.85.221.193]) by dpdk.org (Postfix) with ESMTP id 9FAFD4CC3 for ; Fri, 10 May 2019 15:44:25 +0200 (CEST) Received: by mail-vk1-f193.google.com with SMTP id o187so1484128vkg.4 for ; Fri, 10 May 2019 06:44:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C8CZpjXaPTKdu9ADhujsQJSYPIH9sTPU5+n164JxRYU=; b=p1vPJTv+5L0jqXSIlDw8ovJ2AsJUxag2e5YP7jn3RIvlBY7fEMIQKethe8FTCw+mhN QL1eHrWGK5ivB/RJmiwnZOaPDJjyzANgBSn89fQsXGjglkYhqbyzI5cXDwmbBzjfa2iq torClRbi5bzzFiZWEGVGp8gdzViI32WhOw/JkdI3SOPs8/JBsbpVyYeRVm7/zq3Rl2S6 foIRRxBtQ1RYZPPA8s2X3s7Ro64soSogFQxFPGpg1sLOgRPsC9NzrveIWGXJl4njUqRH RfL+w7MiesQSuK6Xr3/4CZtkm+fNHY8QJtwNAetRd4x8nKEXUbMhaq9MSIlh8Xh+OPah EvOA== X-Gm-Message-State: APjAAAXYg9LzM11FakqfpiVd9DuMgGrd1nvFQeCBzh9O7sgJRoBhexkD HSMFgVNR4Sf1Vcwde3jPKQmU4wQ65nhV/jvDr5LNfg== X-Google-Smtp-Source: APXvYqx0dyS8hf/sqbsuRHN+G9l+wseQZ2T47yphuLMxxr7fyJ3lhHH3R69rVuBXfdrmrSSXIouaTal1C8B5/AodoOg= X-Received: by 2002:a1f:8d0b:: with SMTP id p11mr640522vkd.31.1557495865059; Fri, 10 May 2019 06:44:25 -0700 (PDT) MIME-Version: 1.0 References: <1557355686-4216-1-git-send-email-erik.g.carrillo@intel.com> <1557427905-13766-1-git-send-email-erik.g.carrillo@intel.com> In-Reply-To: <1557427905-13766-1-git-send-email-erik.g.carrillo@intel.com> From: David Marchand Date: Fri, 10 May 2019 15:44:13 +0200 Message-ID: To: Erik Gabriel Carrillo Cc: Thomas Monjalon , Stephen Hemminger , "Burakov, Anatoly" , Bruce Richardson , Ray Kinsella , dev , mw@semihalf.com, mk@semihalf.com, gtzalik@amazon.com, evgenys@amazon.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2] doc: add deprecation notice on EAL mem config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510134413.UQk6iHb0mVBcMkeGq3OtnvETELQ2orW96LKncaz0H4c@z> On Thu, May 9, 2019 at 8:53 PM Erik Gabriel Carrillo < erik.g.carrillo@intel.com> wrote: > It is planned to make the rte_mem_config struct of the EAL private to > remove it from the visible ABI. Add a notice to announce the intention. > > Signed-off-by: Erik Gabriel Carrillo > --- > changes in v2: > - Original deprecation notice announced a change to the rte_mem_config > struct that would break ABI. Update the notice to instead announce > the struct will be made private. (Stephen, Anatoly, David) > > doc/guides/rel_notes/deprecation.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index b47c8c2..a7dff6b 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -31,6 +31,9 @@ Deprecation Notices > > + ``rte_eal_devargs_type_count`` > > +* eal: the ``rte_mem_config`` struct will be made private to remove it > from the > + externally visible ABI and allow it to be updated in the future. > + > * vfio: removal of ``rte_vfio_dma_map`` and ``rte_vfio_dma_unmap`` APIs > which > have been replaced with ``rte_dev_dma_map`` and ``rte_dev_dma_unmap`` > functions. The due date for the removal targets DPDK 20.02. > -- > 2.6.4 > > I had a look at the current callers, trying to see what "hiding" means. $ git grep -Elw '(rte_mem_config|mem_config)' origin/master -- origin/master:app/test/test_memzone.c origin/master:doc/guides/rel_notes/release_18_11.rst origin/master:drivers/bus/fslmc/fslmc_vfio.c origin/master:drivers/net/ena/ena_ethdev.c origin/master:drivers/net/mlx4/mlx4_mr.c origin/master:drivers/net/mlx5/mlx5_mr.c origin/master:drivers/net/virtio/virtio_user/virtio_user_dev.c origin/master:lib/librte_eal/common/eal_common_memory.c origin/master:lib/librte_eal/common/eal_common_memzone.c origin/master:lib/librte_eal/common/eal_common_tailqs.c origin/master:lib/librte_eal/common/include/rte_eal.h origin/master:lib/librte_eal/common/include/rte_eal_memconfig.h origin/master:lib/librte_eal/common/malloc_heap.c origin/master:lib/librte_eal/common/rte_malloc.c origin/master:lib/librte_eal/freebsd/eal/eal.c origin/master:lib/librte_eal/freebsd/eal/eal_memory.c origin/master:lib/librte_eal/linux/eal/eal.c origin/master:lib/librte_eal/linux/eal/eal_memalloc.c origin/master:lib/librte_eal/linux/eal/eal_memory.c origin/master:lib/librte_eal/linux/eal/eal_vfio.c - I understand that the following drivers will need a new lock/unlock api to protect calls to the memory api. drivers/bus/fslmc/fslmc_vfio.c drivers/net/mlx4/mlx4_mr.c drivers/net/mlx5/mlx5_mr.c drivers/net/virtio/virtio_user/virtio_user_dev.c - I have a little trouble with this one, so there might be a new api for this driver usecase. A discussion will have to happen with its maintainers (added in CC:). drivers/net/ena/ena_ethdev.c Apart from this, I am ok with the objective, which is to hide one more eal internal structure. Acked-by: David Marchand -- David Marchand