From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 310E3A0096 for ; Fri, 10 May 2019 20:17:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 291992B95; Fri, 10 May 2019 20:17:27 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id E4316374 for ; Fri, 10 May 2019 20:17:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 6352223B13; Fri, 10 May 2019 14:17:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Fri, 10 May 2019 14:17:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=OSXcpA26XPmAwanOm9y1CCBZmE/Pqk31C73nl6errJs=; b=h0CKG9ClZ4kA 1C4tTMrVOOzI7LztAzy71LPWUuYoglrqQ71PsfRWo0f0wf3B8ufwe8zOsAZywk7d P1ij5wMmPF7IZDvsfKRPvwRVSWuT0C6+j0kF/TLMq2DC+mArJv1tCmdH1y+P5+e/ UyDmfQDLmLtt+5PPnGhRXCA1qYAxhQQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=OSXcpA26XPmAwanOm9y1CCBZmE/Pqk31C73nl6err Js=; b=gNK+ev305mUGLQLJ4A+30Xsv5c8jx5YrbX2qDmx8ERAFPIdRW6moH730U Fg02u8O1G51+JgZlGF12I4CxVV4yY/pivJ7QiSK5T0h2WXlezXnXFL4rYR6t43WT C+CGbvYHdYhhInY1iptNbV1ylDs6Z/nf7euJw1u2hylNx+8qGHMoqvPuggON3oZ0 nhPBvmOEcwnLHKFcN8hmBS6R3HozjgwhIExsHl/gqHeQIynosznUu4ADYx6fpMqH pFDnTkLRW673jSgma9m43aTkaTZSmj4NcZ223adHbIVhP6VHuUv4kPx8ANd9umUo TEpt/fxF+hYzdhM0NRd+SOHAt7WCA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrkeekgdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeekuddrudekhedrudejfedrudegleenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (149.173.185.81.rev.sfr.net [81.185.173.149]) by mail.messagingengine.com (Postfix) with ESMTPA id A6E43103CB; Fri, 10 May 2019 14:17:22 -0400 (EDT) From: Thomas Monjalon To: "Smoczynski, MarcinX" Cc: "Richardson, Bruce" , "dev@dpdk.org" , "Ananyev, Konstantin" , "shahafs@mellanox.com" , "gaetan.rivet@6wind.com" , Adrien Mazarguil , matan@mellanox.com Date: Fri, 10 May 2019 20:17:16 +0200 Message-ID: <9076832.UKkv39EgZr@xps> In-Reply-To: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> References: <2F25558C1648FA498380EAC12A8612624FD953@HASMSX110.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Using _XOPEN_SOURCE macros may break builds on FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190510181716.wt47uX28yQKvNyvyv9hlUoOyoCbrBw77ykHTaOtPwe8@z> 10/05/2019 19:14, Smoczynski, MarcinX: > To summarize we have different visibility sets for Linux and BSD when using > XOPEN_SOURCE or POSIX_C_SOURCE explicitly. To overcome this situation we can > either remove problematic XOPEN macros from mk/meson rules (drivers/net/failsafe, > drivers/net/mlx4, drivers/net/mlx5) What is the consequence of removing these macros in mlx and failsafe PMDs? > or add explicit -D__BSD_VISIBLE when > building for BSD. I think also that defining _GNU_SOURCE for BSD builds makes no > sense although it does not cause any problems. > > I have checked that removing those problematic macros solves build problems on > FreeBSD12 and does not break on Ubuntu 18.04.