From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id F3B0A4C95 for ; Mon, 13 May 2019 16:47:16 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id w22so6897038pgi.6 for ; Mon, 13 May 2019 07:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dzZYXzQfT2W7dJ9LvFLUuJW/oBwiWLbV9AyFmiK0yAs=; b=1OalFwHo5sBO8J7mBxVIjEUbbGn6cluTfRy5hv6vCDpLkCWnPwRsSdkogi1Fr57pzJ vk1xOAAw/cwEjipBQ8wSNAqtFd97aXSJ1Gf+1bLnBLyrym6+ZESeWOaYu3+mapVknmh5 h9Jeno3rxGVdTfQ7AZw0dOJhD8tZpgVWJJEWxZ6MnqrYbaAiDM/5z+BWt2ii46+oJBlL Eg/MkfTXSc67GErTebdyjkS4fva62K1jcdJMAJ/I7j5OK7aK5Dy54Qeujl6F7Aif9hla 2Fm+4IaxCkk/O9IUC+E1q5Jaqe/CvmbKZ8CX8ZuIlVgkBCg0TgX/KmIkwFFOFfrIzZTa HfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dzZYXzQfT2W7dJ9LvFLUuJW/oBwiWLbV9AyFmiK0yAs=; b=uHlf+bLhBjKdTBmsLi2OQtJf1TUrg9VNW8/2WuQaOfOVdEIdNvBA+08yAm2G2BdDWB VFe4j/oc5mdVtFlPYkMvgW4jCpfsPX5TptNVFgbN0QNYxAYEoIIuBWmHapij2RvGkGJv E54xOWc51lP6DTXzUt10FDQbOqSeFabwkj/+KjamnCq2i18vOMG4oRsmF1VSn1RcLshP Kw+Cv3kK/L+lIs4wbZ8vwRWP6ug4PLgIa+VVvCBhg1i2mUSLz8WHgPYnCFzJS4Z2sOtv 5RlqHPkiB0kl/7Of68bqeiwy/U1j9+VRtOtidqtQAoA7rG/NOLuP0dU4uSJTRa5a3jLQ TM3g== X-Gm-Message-State: APjAAAVnk34wIqdLuCehvoHfl+VGzUE23m0B2FEouyRJCHxXkYXEN8T+ PHEbolW/v2SlDsPfoQ9HP05IRQ== X-Google-Smtp-Source: APXvYqy6gqfeWa1rV1Z2Rl8TQJOUyTUI9M3NkXngxMqMSEhmamRRs73Z/giQsBpNU9c+z5/kNdKJvA== X-Received: by 2002:a63:246:: with SMTP id 67mr31786520pgc.145.1557758835957; Mon, 13 May 2019 07:47:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v1sm21115267pgb.85.2019.05.13.07.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 07:47:15 -0700 (PDT) Date: Mon, 13 May 2019 07:47:08 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Olivier Matz" , , , , Message-ID: <20190513074708.775d0559@hermes.lan> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> References: <1557509654-19325-1-git-send-email-mb@smartsharesystems.com> <20190513115439.5fjarh6au7u64fmq@platinum> <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 14:47:17 -0000 On Mon, 13 May 2019 15:02:57 +0200 Morten Br=C3=B8rup wrote: > >=20 > > IMHO, adding the copyright for flags move is a bit overkill. =20 >=20 > I also added the two ECN flags and descriptions of all the flags. And rem= oved the misleading ALL flag. >=20 > I don't know the formal or customary threshold criteria for adding a copy= right notice, so I just added it. It's our first direct contribution where = we didn't just send the corrections to another contributor, so I thought it= would be nice to have our name in here. You're the maintainer, so I'll lea= ve the final decision up to you. Most projects including DPDK do not add additional copyrights unless it is a complete rewrite. Please don't clutter the code with this stuff. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D5F8BA00E6 for ; Mon, 13 May 2019 16:47:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6668F4C9C; Mon, 13 May 2019 16:47:18 +0200 (CEST) Received: from mail-pg1-f194.google.com (mail-pg1-f194.google.com [209.85.215.194]) by dpdk.org (Postfix) with ESMTP id F3B0A4C95 for ; Mon, 13 May 2019 16:47:16 +0200 (CEST) Received: by mail-pg1-f194.google.com with SMTP id w22so6897038pgi.6 for ; Mon, 13 May 2019 07:47:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dzZYXzQfT2W7dJ9LvFLUuJW/oBwiWLbV9AyFmiK0yAs=; b=1OalFwHo5sBO8J7mBxVIjEUbbGn6cluTfRy5hv6vCDpLkCWnPwRsSdkogi1Fr57pzJ vk1xOAAw/cwEjipBQ8wSNAqtFd97aXSJ1Gf+1bLnBLyrym6+ZESeWOaYu3+mapVknmh5 h9Jeno3rxGVdTfQ7AZw0dOJhD8tZpgVWJJEWxZ6MnqrYbaAiDM/5z+BWt2ii46+oJBlL Eg/MkfTXSc67GErTebdyjkS4fva62K1jcdJMAJ/I7j5OK7aK5Dy54Qeujl6F7Aif9hla 2Fm+4IaxCkk/O9IUC+E1q5Jaqe/CvmbKZ8CX8ZuIlVgkBCg0TgX/KmIkwFFOFfrIzZTa HfXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dzZYXzQfT2W7dJ9LvFLUuJW/oBwiWLbV9AyFmiK0yAs=; b=uHlf+bLhBjKdTBmsLi2OQtJf1TUrg9VNW8/2WuQaOfOVdEIdNvBA+08yAm2G2BdDWB VFe4j/oc5mdVtFlPYkMvgW4jCpfsPX5TptNVFgbN0QNYxAYEoIIuBWmHapij2RvGkGJv E54xOWc51lP6DTXzUt10FDQbOqSeFabwkj/+KjamnCq2i18vOMG4oRsmF1VSn1RcLshP Kw+Cv3kK/L+lIs4wbZ8vwRWP6ug4PLgIa+VVvCBhg1i2mUSLz8WHgPYnCFzJS4Z2sOtv 5RlqHPkiB0kl/7Of68bqeiwy/U1j9+VRtOtidqtQAoA7rG/NOLuP0dU4uSJTRa5a3jLQ TM3g== X-Gm-Message-State: APjAAAVnk34wIqdLuCehvoHfl+VGzUE23m0B2FEouyRJCHxXkYXEN8T+ PHEbolW/v2SlDsPfoQ9HP05IRQ== X-Google-Smtp-Source: APXvYqy6gqfeWa1rV1Z2Rl8TQJOUyTUI9M3NkXngxMqMSEhmamRRs73Z/giQsBpNU9c+z5/kNdKJvA== X-Received: by 2002:a63:246:: with SMTP id 67mr31786520pgc.145.1557758835957; Mon, 13 May 2019 07:47:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id v1sm21115267pgb.85.2019.05.13.07.47.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 13 May 2019 07:47:15 -0700 (PDT) Date: Mon, 13 May 2019 07:47:08 -0700 From: Stephen Hemminger To: Morten =?UTF-8?B?QnLDuHJ1cA==?= Cc: "Olivier Matz" , , , , Message-ID: <20190513074708.775d0559@hermes.lan> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> References: <1557509654-19325-1-git-send-email-mb@smartsharesystems.com> <20190513115439.5fjarh6au7u64fmq@platinum> <98CBD80474FA8B44BF855DF32C47DC35B42847@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513144708.-oPhQtfOiQthqnpjZ7xRMGp8cS4e-J0hrBw8vTu4hDY@z> On Mon, 13 May 2019 15:02:57 +0200 Morten Br=C3=B8rup wrote: > >=20 > > IMHO, adding the copyright for flags move is a bit overkill. =20 >=20 > I also added the two ECN flags and descriptions of all the flags. And rem= oved the misleading ALL flag. >=20 > I don't know the formal or customary threshold criteria for adding a copy= right notice, so I just added it. It's our first direct contribution where = we didn't just send the corrections to another contributor, so I thought it= would be nice to have our name in here. You're the maintainer, so I'll lea= ve the final decision up to you. Most projects including DPDK do not add additional copyrights unless it is a complete rewrite. Please don't clutter the code with this stuff.