From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 3E4BC3253 for ; Mon, 13 May 2019 13:59:54 +0200 (CEST) Received: from lfbn-lil-1-768-100.w81-254.abo.wanadoo.fr ([81.254.99.100] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQ9fC-0001bt-MN; Mon, 13 May 2019 14:02:39 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 13 May 2019 13:59:52 +0200 Date: Mon, 13 May 2019 13:59:51 +0200 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190513115951.o3a6lj4rcb24q5gy@platinum> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-2-olivier.matz@6wind.com> <20190422090045.695deff5@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422090045.695deff5@hermes.lan> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 11:59:54 -0000 Hi Stephen, On Mon, Apr 22, 2019 at 09:00:45AM -0700, Stephen Hemminger wrote: > On Wed, 10 Apr 2019 10:32:05 +0200 > Olivier Matz wrote: > > > Add 'rte_' prefix to structures: > > - rename struct arp_hdr as struct rte_arp_hdr. > > - rename struct arp_ipv4 as struct rte_arp_ipv4. > > > > Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields > > to avoid conflict with the #defines in gnu libc. > > > > Signed-off-by: Olivier Matz > > Agree that adding prefix is best way to handle rte_arp.h. > > Could you fix up all the checkpatch whitespace warnings on > this and resubmit it as a PATCH (not RFC)? I don't think fixing all whitespace warnings in the patchset is a good thing. It's not new code, and only fixing the parts I'm modifying may result in style inconsistency. I'll have a look on a case by case basis. Thanks Olivier From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id EF1CCA00E6 for ; Mon, 13 May 2019 13:59:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 254E34C9D; Mon, 13 May 2019 13:59:55 +0200 (CEST) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 3E4BC3253 for ; Mon, 13 May 2019 13:59:54 +0200 (CEST) Received: from lfbn-lil-1-768-100.w81-254.abo.wanadoo.fr ([81.254.99.100] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQ9fC-0001bt-MN; Mon, 13 May 2019 14:02:39 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 13 May 2019 13:59:52 +0200 Date: Mon, 13 May 2019 13:59:51 +0200 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190513115951.o3a6lj4rcb24q5gy@platinum> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-2-olivier.matz@6wind.com> <20190422090045.695deff5@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190422090045.695deff5@hermes.lan> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC v2 01/14] net: add rte prefix to arp structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513115951.F7qGWLOH1dsYDG7IP_AHZz_Pfu_nrQpADK-VgGJDps8@z> Hi Stephen, On Mon, Apr 22, 2019 at 09:00:45AM -0700, Stephen Hemminger wrote: > On Wed, 10 Apr 2019 10:32:05 +0200 > Olivier Matz wrote: > > > Add 'rte_' prefix to structures: > > - rename struct arp_hdr as struct rte_arp_hdr. > > - rename struct arp_ipv4 as struct rte_arp_ipv4. > > > > Also rename arp_hrd, arp_pro, arp_hln, arp_pln and arp_op fields > > to avoid conflict with the #defines in gnu libc. > > > > Signed-off-by: Olivier Matz > > Agree that adding prefix is best way to handle rte_arp.h. > > Could you fix up all the checkpatch whitespace warnings on > this and resubmit it as a PATCH (not RFC)? I don't think fixing all whitespace warnings in the patchset is a good thing. It's not new code, and only fixing the parts I'm modifying may result in style inconsistency. I'll have a look on a case by case basis. Thanks Olivier