From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B31B43253 for ; Mon, 13 May 2019 14:02:48 +0200 (CEST) Received: from lfbn-lil-1-768-100.w81-254.abo.wanadoo.fr ([81.254.99.100] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQ9i0-0001cR-Ox; Mon, 13 May 2019 14:05:34 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 13 May 2019 14:02:46 +0200 Date: Mon, 13 May 2019 14:02:46 +0200 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190513120246.c6rhx6525adnbvgt@platinum> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-12-olivier.matz@6wind.com> <20190422090554.2e1af55d@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190422090554.2e1af55d@hermes.lan> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC v2 11/14] net: add rte prefix to ip defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 May 2019 12:02:49 -0000 On Mon, Apr 22, 2019 at 09:05:54AM -0700, Stephen Hemminger wrote: > On Wed, 10 Apr 2019 10:32:15 +0200 > Olivier Matz wrote: > > > diff --git a/app/test-acl/main.c b/app/test-acl/main.c > > index b80179417..eb6294396 100644 > > --- a/app/test-acl/main.c > > +++ b/app/test-acl/main.c > > @@ -625,7 +625,7 @@ parse_ipv4_net(const char *in, uint32_t *addr, uint32_t *mask_len) > > GET_CB_FIELD(in, d, 0, UINT8_MAX, '/'); > > GET_CB_FIELD(in, m, 0, sizeof(uint32_t) * CHAR_BIT, 0); > > > > - addr[0] = IPv4(a, b, c, d); > > + addr[0] = RTE_IPv4(a, b, c, d); > > IPv4 is a DPDK only macro, could you leave it alone. It is a public macro defined in rte_ip.h. I think we should prefix it, to move it in the dpdk namespace. This would avoid conflicts with an application defining its own IPv4() macro. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 53FF8A00E6 for ; Mon, 13 May 2019 14:02:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 43EBE4C9D; Mon, 13 May 2019 14:02:50 +0200 (CEST) Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id B31B43253 for ; Mon, 13 May 2019 14:02:48 +0200 (CEST) Received: from lfbn-lil-1-768-100.w81-254.abo.wanadoo.fr ([81.254.99.100] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hQ9i0-0001cR-Ox; Mon, 13 May 2019 14:05:34 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 13 May 2019 14:02:46 +0200 Date: Mon, 13 May 2019 14:02:46 +0200 From: Olivier Matz To: Stephen Hemminger Cc: dev@dpdk.org, Ferruh Yigit Message-ID: <20190513120246.c6rhx6525adnbvgt@platinum> References: <20181024081833.21432-1-olivier.matz@6wind.com> <20190410083218.17531-1-olivier.matz@6wind.com> <20190410083218.17531-12-olivier.matz@6wind.com> <20190422090554.2e1af55d@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190422090554.2e1af55d@hermes.lan> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [RFC v2 11/14] net: add rte prefix to ip defines X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190513120246.Sq6vjGaKR7_ea2Zb-KsjA1VQJQZlMTPNAmAPgMdcYX8@z> On Mon, Apr 22, 2019 at 09:05:54AM -0700, Stephen Hemminger wrote: > On Wed, 10 Apr 2019 10:32:15 +0200 > Olivier Matz wrote: > > > diff --git a/app/test-acl/main.c b/app/test-acl/main.c > > index b80179417..eb6294396 100644 > > --- a/app/test-acl/main.c > > +++ b/app/test-acl/main.c > > @@ -625,7 +625,7 @@ parse_ipv4_net(const char *in, uint32_t *addr, uint32_t *mask_len) > > GET_CB_FIELD(in, d, 0, UINT8_MAX, '/'); > > GET_CB_FIELD(in, m, 0, sizeof(uint32_t) * CHAR_BIT, 0); > > > > - addr[0] = IPv4(a, b, c, d); > > + addr[0] = RTE_IPv4(a, b, c, d); > > IPv4 is a DPDK only macro, could you leave it alone. It is a public macro defined in rte_ip.h. I think we should prefix it, to move it in the dpdk namespace. This would avoid conflicts with an application defining its own IPv4() macro.