From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Morten Brørup" <mb@smartsharesystems.com>,
"Stephen Hemminger" <stephen@networkplumber.org>
Cc: Olivier Matz <olivier.matz@6wind.com>,
thomas@monjalon.net, arybchenko@solarflare.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h instead of in rte_eth_ctrl.h
Date: Mon, 13 May 2019 18:00:07 +0100 [thread overview]
Message-ID: <81579a34-1685-ce1a-f16f-fa0faed3706f@intel.com> (raw)
Message-ID: <20190513170007.vx3Px6mucvU9h58CmCoP6RohB8-uVb4N0MaON1wpMKs@z> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35B4284A@smartserver.smartshare.dk>
On 5/13/2019 4:15 PM, Morten Brørup wrote:
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Stephen Hemminger
>> Sent: Monday, May 13, 2019 4:47 PM
>> To: Morten Brørup
>> Cc: Olivier Matz; thomas@monjalon.net; ferruh.yigit@intel.com;
>> arybchenko@solarflare.com; dev@dpdk.org
>> Subject: Re: [dpdk-dev] [PATCH] librte_net: define TCP flags in rte_tcp.h
>> instead of in rte_eth_ctrl.h
>>
>> On Mon, 13 May 2019 15:02:57 +0200
>> Morten Brørup <mb@smartsharesystems.com> wrote:
>>
>>>>
>>>> IMHO, adding the copyright for flags move is a bit overkill.
>>>
>>> I also added the two ECN flags and descriptions of all the flags. And
>> removed the misleading ALL flag.
>>>
>>> I don't know the formal or customary threshold criteria for adding a
>> copyright notice, so I just added it. It's our first direct contribution
>> where we didn't just send the corrections to another contributor, so I
>> thought it would be nice to have our name in here. You're the maintainer,
>> so I'll leave the final decision up to you.
>>
>> Most projects including DPDK do not add additional copyrights unless it
>> is a complete rewrite. Please don't clutter the code with this stuff.
>
> That's a quite clear threshold definition, and my modifications clearly don't fall into this category.
I think in the past threshold has been mentioned as "significant contribution",
although this is kind of vague, it sounds lighter than "complete rewrite",
anyway I agree for this patch it looks overkill to claim the copyright.
>
> Med venlig hilsen / kind regards
> - Morten Brørup
>
next prev parent reply other threads:[~2019-05-13 17:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 17:34 Morten Brørup
2019-05-10 17:34 ` Morten Brørup
2019-05-13 11:54 ` Olivier Matz
2019-05-13 11:54 ` Olivier Matz
2019-05-13 13:02 ` Morten Brørup
2019-05-13 13:02 ` Morten Brørup
2019-05-13 14:47 ` Stephen Hemminger
2019-05-13 14:47 ` Stephen Hemminger
2019-05-13 15:15 ` Morten Brørup
2019-05-13 15:15 ` Morten Brørup
2019-05-13 17:00 ` Ferruh Yigit [this message]
2019-05-13 17:00 ` Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2019-05-10 17:10 Morten Brørup
2019-05-10 17:10 ` Morten Brørup
2019-05-10 16:10 Morten Brørup
2019-05-10 16:10 ` Morten Brørup
2019-05-10 14:10 Morten Brørup
2019-05-10 14:10 ` Morten Brørup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=81579a34-1685-ce1a-f16f-fa0faed3706f@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=olivier.matz@6wind.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).