From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id B32CE5F14 for ; Tue, 14 May 2019 17:27:41 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id f12so6418551plt.8 for ; Tue, 14 May 2019 08:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4BU0nZJNkSpXEPXoLV2rErsYieOD6y15DCD1XaRUm3s=; b=HYBUvV37I8IgqkKort28OQlcmvgjwNH8D8cpivBL8+a1lRkMr/NusH/kr+MtJyHZUg Kxvlcj6gIch5JltcODCl2qC4+uaOnUWiB1o52yhZliaYrsAe+ydaXdoWNdlBQ8ecntWm s3LdP05xaiDwKTi4+8TY9PGqsDu7fhfmrjy0psVn0t3q4sRl2T6EYx+g34SYBwHRyi+0 4f+KLpDPeOyf/Y5VBWtxCxKNzNlSqpE6AzaKVL/xSqi7fD6W5wQSWLCZjpSda45vWxzW 6zx4whPMGHZtv0/qa0O+G0rhFA5bf+iD/UlvTVJEVQY93ca3ia4AZaHoHEVKiuhEdoBc ZI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4BU0nZJNkSpXEPXoLV2rErsYieOD6y15DCD1XaRUm3s=; b=ISS7D0rL8t0wTMw/bcMfDALr3yP1QWBPcFuP3Hpyt/eSmY3S6376CZzfb4rAr2y/Ko Zs9sda/6XKciCunlavQM/kGuS2sgDN9YHEawEUjkK3xzYdDYA8Xu2AHmVPd96Ujr1cwg VmpMSSlIO8INQ62Rqpw56lOl8oi3t1BLlbEC+otknfS9VBOaa1yaZE+1+WxQ30XcgMNl L96u/5SnoRK1dII/ANq2cZWDE6UYMdJWVWpAzo4r4qq0978Eo2nlYu92Too08UlNXpOr A8+ZiuojknxrkFWBpoZVBFeirHZbI4kX9CHfLZ/w8xWtNgedZixWOPdDKLzTOx0xmqH3 /nVg== X-Gm-Message-State: APjAAAUF1LEAheJMnnrs+66jBn1rVeVbAh3lzyAcwxD1EP07WJ/t12Iu PbYRQtmwxVAI8pLlirNdW8lCIA== X-Google-Smtp-Source: APXvYqyCtOG5HI3B8qvpuSM7vRU6kZ//QQK5UkMRGSTnbUHenmHS5bHez2b6GK7w34UUM2QypZAhtQ== X-Received: by 2002:a17:902:407:: with SMTP id 7mr38384267ple.62.1557847660800; Tue, 14 May 2019 08:27:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r138sm29669544pfr.2.2019.05.14.08.27.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 08:27:40 -0700 (PDT) Date: Tue, 14 May 2019 08:27:33 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: , , , Message-ID: <20190514082733.4941fce6@hermes.lan> In-Reply-To: <20190514092046.30808-2-mattias.ronnblom@ericsson.com> References: <20190508181014.7dde7580@xps13> <20190514092046.30808-1-mattias.ronnblom@ericsson.com> <20190514092046.30808-2-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 May 2019 15:27:42 -0000 On Tue, 14 May 2019 11:20:41 +0200 Mattias R=C3=B6nnblom wrote: > +RTE_INIT(rte_rand_init) > +{ > + rte_srand(rte_get_timer_cycles()); > +} Please make initialization OS specific and use get_random() on Linux. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C0915A00E6 for ; Tue, 14 May 2019 17:27:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 866F77CCF; Tue, 14 May 2019 17:27:42 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id B32CE5F14 for ; Tue, 14 May 2019 17:27:41 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id f12so6418551plt.8 for ; Tue, 14 May 2019 08:27:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=4BU0nZJNkSpXEPXoLV2rErsYieOD6y15DCD1XaRUm3s=; b=HYBUvV37I8IgqkKort28OQlcmvgjwNH8D8cpivBL8+a1lRkMr/NusH/kr+MtJyHZUg Kxvlcj6gIch5JltcODCl2qC4+uaOnUWiB1o52yhZliaYrsAe+ydaXdoWNdlBQ8ecntWm s3LdP05xaiDwKTi4+8TY9PGqsDu7fhfmrjy0psVn0t3q4sRl2T6EYx+g34SYBwHRyi+0 4f+KLpDPeOyf/Y5VBWtxCxKNzNlSqpE6AzaKVL/xSqi7fD6W5wQSWLCZjpSda45vWxzW 6zx4whPMGHZtv0/qa0O+G0rhFA5bf+iD/UlvTVJEVQY93ca3ia4AZaHoHEVKiuhEdoBc ZI7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4BU0nZJNkSpXEPXoLV2rErsYieOD6y15DCD1XaRUm3s=; b=ISS7D0rL8t0wTMw/bcMfDALr3yP1QWBPcFuP3Hpyt/eSmY3S6376CZzfb4rAr2y/Ko Zs9sda/6XKciCunlavQM/kGuS2sgDN9YHEawEUjkK3xzYdDYA8Xu2AHmVPd96Ujr1cwg VmpMSSlIO8INQ62Rqpw56lOl8oi3t1BLlbEC+otknfS9VBOaa1yaZE+1+WxQ30XcgMNl L96u/5SnoRK1dII/ANq2cZWDE6UYMdJWVWpAzo4r4qq0978Eo2nlYu92Too08UlNXpOr A8+ZiuojknxrkFWBpoZVBFeirHZbI4kX9CHfLZ/w8xWtNgedZixWOPdDKLzTOx0xmqH3 /nVg== X-Gm-Message-State: APjAAAUF1LEAheJMnnrs+66jBn1rVeVbAh3lzyAcwxD1EP07WJ/t12Iu PbYRQtmwxVAI8pLlirNdW8lCIA== X-Google-Smtp-Source: APXvYqyCtOG5HI3B8qvpuSM7vRU6kZ//QQK5UkMRGSTnbUHenmHS5bHez2b6GK7w34UUM2QypZAhtQ== X-Received: by 2002:a17:902:407:: with SMTP id 7mr38384267ple.62.1557847660800; Tue, 14 May 2019 08:27:40 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id r138sm29669544pfr.2.2019.05.14.08.27.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 14 May 2019 08:27:40 -0700 (PDT) Date: Tue, 14 May 2019 08:27:33 -0700 From: Stephen Hemminger To: Mattias =?UTF-8?B?UsO2bm5ibG9t?= Cc: , , , Message-ID: <20190514082733.4941fce6@hermes.lan> In-Reply-To: <20190514092046.30808-2-mattias.ronnblom@ericsson.com> References: <20190508181014.7dde7580@xps13> <20190514092046.30808-1-mattias.ronnblom@ericsson.com> <20190514092046.30808-2-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/6] eal: replace libc-based random number generation with LFSR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190514152733.qlPbqNvmw7L7ay21MISeUwJASE4IL-EtL5XqBxoqOMI@z> On Tue, 14 May 2019 11:20:41 +0200 Mattias R=C3=B6nnblom wrote: > +RTE_INIT(rte_rand_init) > +{ > + rte_srand(rte_get_timer_cycles()); > +} Please make initialization OS specific and use get_random() on Linux.