From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 3A994A00E6 for ; Tue, 14 May 2019 13:44:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 53778569B; Tue, 14 May 2019 13:44:44 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 7D6FA5398 for ; Tue, 14 May 2019 13:44:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 May 2019 04:44:41 -0700 X-ExtLoop1: 1 Received: from msmoczyx-mobl.ger.corp.intel.com ([10.104.12.183]) by orsmga001.jf.intel.com with ESMTP; 14 May 2019 04:44:39 -0700 From: Marcin Smoczynski To: bruce.richardson@intel.com, thomas@monjalon.net Cc: dev@dpdk.org, konstantin.ananyev@intel.com, adrien.mazarguil@6wind.com, Marcin Smoczynski Date: Tue, 14 May 2019 13:43:54 +0200 Message-Id: <20190514114354.16212-1-marcinx.smoczynski@intel.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Content-Type: text/plain; charset="UTF-8" Message-ID: <20190514114354.QE0oxmHHZ13ii1vVTq3blVaTpeZuiAqw6pUZzPcmMNo@z> When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro explicitly in its build recipe, it restricts visibility of a non POSIX features subset, such as IANA protocol numbers (IPPROTO_* macros). Non standard features are enabled by default for DPDK both for Linux thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature sets visibility for Linux and FreeBSD. It restricts from using IPPROTO macros in public headers, such as rte_ip.h, despite the fact they are already widely used in sources. Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets which enforces feature sets visibility unification between Linux and FreeBSD. This patch solves the problem of build breaks for [1] on FreeBSD [2] following the discussion [3]. [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html Signed-off-by: Marcin Smoczynski --- app/meson.build | 5 +++++ drivers/meson.build | 5 +++++ examples/meson.build | 5 +++++ lib/meson.build | 5 +++++ mk/target/generic/rte.vars.mk | 5 +++++ 5 files changed, 25 insertions(+) diff --git a/app/meson.build b/app/meson.build index 2b9fdef74..eb04c4e46 100644 --- a/app/meson.build +++ b/app/meson.build @@ -25,6 +25,11 @@ default_cflags = machine_args # specify -D_GNU_SOURCE unconditionally default_cflags += '-D_GNU_SOURCE' +# specify -D__BSD_VISIBLE for FreeBSD +if is_freebsd + default_cflags += '-D__BSD_VISIBLE' +endif + foreach app:apps build = true name = app diff --git a/drivers/meson.build b/drivers/meson.build index 4c444f495..a1a2dfcca 100644 --- a/drivers/meson.build +++ b/drivers/meson.build @@ -24,6 +24,11 @@ endif # specify -D_GNU_SOURCE unconditionally default_cflags += '-D_GNU_SOURCE' +# specify -D__BSD_VISIBLE for FreeBSD +if is_freebsd + default_cflags += '-D__BSD_VISIBLE' +endif + foreach class:dpdk_driver_classes drivers = [] std_deps = [] diff --git a/examples/meson.build b/examples/meson.build index 1a6134f12..44dfdc97f 100644 --- a/examples/meson.build +++ b/examples/meson.build @@ -34,6 +34,11 @@ endif # specify -D_GNU_SOURCE unconditionally default_cflags += '-D_GNU_SOURCE' +# specify -D__BSD_VISIBLE for FreeBSD +if is_freebsd + default_cflags += '-D__BSD_VISIBLE' +endif + foreach example: examples name = example build = true diff --git a/lib/meson.build b/lib/meson.build index e067ce5ea..48592c35a 100644 --- a/lib/meson.build +++ b/lib/meson.build @@ -44,6 +44,11 @@ enabled_libs = [] # used to print summary at the end # -D_GNU_SOURCE unconditionally default_cflags += '-D_GNU_SOURCE' +# specify -D__BSD_VISIBLE for FreeBSD +if is_freebsd + default_cflags += '-D__BSD_VISIBLE' +endif + foreach l:libraries build = true name = l diff --git a/mk/target/generic/rte.vars.mk b/mk/target/generic/rte.vars.mk index 25a578ad7..5f00a0bfa 100644 --- a/mk/target/generic/rte.vars.mk +++ b/mk/target/generic/rte.vars.mk @@ -111,6 +111,11 @@ endif # always define _GNU_SOURCE CFLAGS += -D_GNU_SOURCE +# define __BSD_VISIBLE when building for FreeBSD +ifeq ($(CONFIG_RTE_EXEC_ENV_FREEBSD),y) +CFLAGS += -D__BSD_VISIBLE +endif + export CFLAGS export LDFLAGS -- 2.21.0.windows.1