From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Marcin Smoczynski <marcinx.smoczynski@intel.com>
Cc: bruce.richardson@intel.com, thomas@monjalon.net, dev@dpdk.org,
konstantin.ananyev@intel.com
Subject: Re: [dpdk-dev] [PATCH] build: enable BSD features visibility for FreeBSD
Date: Tue, 14 May 2019 13:49:45 +0200 [thread overview]
Message-ID: <20190514114945.GP4284@6wind.com> (raw)
Message-ID: <20190514114945.GibbzmFa1MZbgC7SrSHh6lGaTLhiaGp_rnXbiCcH-Es@z> (raw)
In-Reply-To: <20190514114354.16212-1-marcinx.smoczynski@intel.com>
On Tue, May 14, 2019 at 01:43:54PM +0200, Marcin Smoczynski wrote:
> When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro
> explicitly in its build recipe, it restricts visibility of a non POSIX
> features subset, such as IANA protocol numbers (IPPROTO_* macros).
> Non standard features are enabled by default for DPDK both for Linux
> thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However
> using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes
> __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature
> sets visibility for Linux and FreeBSD. It restricts from using IPPROTO
> macros in public headers, such as rte_ip.h, despite the fact they are
> already widely used in sources.
>
> Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets
> which enforces feature sets visibility unification between Linux and
> FreeBSD.
>
> This patch solves the problem of build breaks for [1] on FreeBSD [2]
> following the discussion [3].
>
> [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html
> [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html
> [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html
>
> Signed-off-by: Marcin Smoczynski <marcinx.smoczynski@intel.com>
Thanks!
Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2019-05-14 11:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 11:43 Marcin Smoczynski
2019-05-14 11:43 ` Marcin Smoczynski
2019-05-14 11:49 ` Adrien Mazarguil [this message]
2019-05-14 11:49 ` Adrien Mazarguil
2019-05-14 12:20 ` Bruce Richardson
2019-05-14 12:20 ` Bruce Richardson
2019-05-14 13:15 ` Smoczynski, MarcinX
2019-05-14 13:15 ` Smoczynski, MarcinX
2019-05-14 13:19 ` Bruce Richardson
2019-05-14 13:19 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514114945.GP4284@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=marcinx.smoczynski@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).