DPDK patches and discussions
 help / color / mirror / Atom feed
From: Igor Russkikh <Igor.Russkikh@aquantia.com>
To: "Stillwell Jr, Paul M" <paul.m.stillwell.jr@intel.com>,
	Ido Goshen <Ido@cgstowernetworks.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	"Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: 10GBASE-T SFP+ copper support
Date: Tue, 14 May 2019 12:21:31 +0000	[thread overview]
Message-ID: <1a1b4139-dcaa-9d2e-5a1d-fa247c84c250@aquantia.com> (raw)
Message-ID: <20190514122131.JX-M5om5NnX-a6A3EGqw61w3DXbmq4KtQQzITPhXDug@z> (raw)
In-Reply-To: <F8A4ECA1C1D86B4081DD6BF503D1F436C7495131@fmsmsx120.amr.corp.intel.com>


>>> 	TABLE 5-3 TRANSCEIVER COMPLIANCE CODES
>>> 	10G Ethernet Compliance Codes
>>> 	3 	7 	10G Base-ER
>>> 	3 	6 	10G Base-LRM
>>> 	3 	5 	10G Base-LR
>>> 	3 	4 	10G Base-SR
>>> 	Infiniband Compliance Codes
>>> 	3 	3 	1X SX
>>> 	3 	2 	1X LX
>>> 	3 	1 	1X Copper Active
>>> 	3 	0 	1X Copper Active
>>> Seems they are right not to set any code from above, no?
>>>
>>> Do you know any 10GBASE-T SFPs that does work?
>>> Any idea what does it return for this field?
>>>
>>
>> I can confirm we saw the same issues using Aquantia SFP+ Copper modules
>> with 550 MAC. Indeed there is no separate id for Base-T.
>>
>> ixgbe logic both in kernel and dpdk discards such modules.
>>
>> Regards,
>>   Igor
> 
> The issue is really that there are bad modules out there and Intel only supports the ones that have been tested in our labs and verified to consistently work. We get too many support tickets for modules that don't work and so the best thing for us to do is to test some set of modules, verify they work, mark them as supported, and move on.
> 
> Feel free to apply this patch to your local repo and move on, but we can't support these modules in the code and will not accept a patch to support them.

That's reasonable, but then all the rationality of `hw->allow_unsupported_sfp`
goes away, as you do not allow the particular type (copper) of unsupported sfps.

Regards,
  Igor

  parent reply	other threads:[~2019-05-14 12:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 11:31 Ido Goshen
2019-04-24 11:31 ` Ido Goshen
2019-04-24 11:47 ` Ananyev, Konstantin
2019-04-24 11:47   ` Ananyev, Konstantin
2019-04-24 21:25   ` Ido Goshen
2019-04-24 21:25     ` Ido Goshen
2019-04-26 12:13     ` Ananyev, Konstantin
2019-04-26 12:13       ` Ananyev, Konstantin
2019-04-28  6:54       ` Ido Goshen
2019-04-28  6:54         ` Ido Goshen
2019-05-01 23:40         ` Ananyev, Konstantin
2019-05-01 23:40           ` Ananyev, Konstantin
2019-05-02  9:15           ` Ido Goshen
2019-05-02  9:15             ` Ido Goshen
2019-05-06 11:22             ` Igor Russkikh
2019-05-06 11:22               ` Igor Russkikh
2019-05-07 22:45               ` Stillwell Jr, Paul M
2019-05-07 22:45                 ` Stillwell Jr, Paul M
2019-05-14 12:21                 ` Igor Russkikh [this message]
2019-05-14 12:21                   ` Igor Russkikh
2019-05-14 17:10                 ` Ido Goshen
2019-05-14 17:10                   ` Ido Goshen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1a1b4139-dcaa-9d2e-5a1d-fa247c84c250@aquantia.com \
    --to=igor.russkikh@aquantia.com \
    --cc=Ido@cgstowernetworks.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=paul.m.stillwell.jr@intel.com \
    --cc=wenzhuo.lu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).