DPDK patches and discussions
 help / color / mirror / Atom feed
From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [dpdk-dev] [Bug 278] bond_ethdev_rx_burst multithread access bond's different queue will crash
Date: Wed, 15 May 2019 06:18:30 +0000	[thread overview]
Message-ID: <bug-278-3@http.bugs.dpdk.org/> (raw)
Message-ID: <20190515061830.Lw3ZzPBg2Kn5rNvL6GcMCGe5krWvDOKIR2Y01S1OS8Y@z> (raw)

https://bugs.dpdk.org/show_bug.cgi?id=278

            Bug ID: 278
           Summary: bond_ethdev_rx_burst multithread access bond's
                    different queue will crash
           Product: DPDK
           Version: 18.11
          Hardware: All
                OS: All
            Status: CONFIRMED
          Severity: normal
          Priority: Normal
         Component: ethdev
          Assignee: dev@dpdk.org
          Reporter: wavespider@sina.com
  Target Milestone: ---

when multi-thread access net-bonding interface's different queue, calling
function 
 below will result in crash because of "out of array boundary":
rte_eth_rx_burst
  -> bond_ethdev_rx_burst

one thread loop over and update internals->active_slave:
if (++internals->active_slave >= slave_count) 
        internals->active_slave = 0;
another thread just read internals->active_slave, maybe equal slave_count:

active_slave = internals->active_slave;
num_rx_slave =
        rte_eth_rx_burst(internals->active_slaves[active_slave], /*Here out of
boundary*/
                 bd_rx_q->queue_id,
                 bufs + num_rx_total, nb_pkts);

default, internals->active_slaves[active_slave] maybe the value is 0, then call
rte_eth_rx_burst function:

port-id == 0 and queue_id = 20 (example):
when port-id == 0's interface have not enough queue-number(<20), then will
result in crash ( dev->data->rx_queues[queue_id] == NULL pointer access ).

-- 
You are receiving this mail because:
You are the assignee for the bug.

             reply	other threads:[~2019-05-15  6:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15  6:18 bugzilla [this message]
2019-05-15  6:18 ` bugzilla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-278-3@http.bugs.dpdk.org/ \
    --to=bugzilla@dpdk.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).