From: Dekel Peled <dekelp@mellanox.com>
To: yskoh@mellanox.com, shahafs@mellanox.com
Cc: dev@dpdk.org, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] net/mlx5: fix order of items in neon scatter func
Date: Wed, 15 May 2019 13:07:45 +0300 [thread overview]
Message-ID: <1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com> (raw)
Message-ID: <20190515100745.qGC1HMl-QGSuOK3yZIYoh5NdmimH_vueMxSHL6mX5pA@z> (raw)
Previous patch added handling of metadata for multi-segment packet.
Function txq_scatter_v in file mlx5_rxtx_vec_neon.h was updated
incorrectly, items were inserted into WQE in wrong order.
This patch fixes the issue, inserting items into WQE correctly.
Fixes: 7f4019d370f6 ("net/mlx5: fix Tx metadata for multi-segment packet")
Cc: stable@dpdk.org
Signed-off-by: Dekel Peled <dekelp@mellanox.com>
---
drivers/net/mlx5/mlx5_rxtx_vec_neon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
index 38e915c..b1e0e8f 100644
--- a/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
+++ b/drivers/net/mlx5/mlx5_rxtx_vec_neon.h
@@ -171,7 +171,7 @@
/* Fill ESEG in the header. */
vst1q_u32((void *)(t_wqe + 1),
((uint32x4_t){ 0,
- cs_flags << 16 | rte_cpu_to_be_16(len),
+ rte_cpu_to_be_16(len) << 16 | cs_flags,
metadata, 0 }));
txq->wqe_ci = wqe_ci;
}
--
1.8.3.1
next reply other threads:[~2019-05-15 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 10:07 Dekel Peled [this message]
2019-05-15 10:07 ` Dekel Peled
2019-05-26 18:49 ` Shahaf Shuler
2019-05-27 6:50 ` Dekel Peled
2019-06-02 7:53 ` Shahaf Shuler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e43edbc1aa11055521150f5be724278aa1247e6.1557915012.git.dekelp@mellanox.com \
--to=dekelp@mellanox.com \
--cc=dev@dpdk.org \
--cc=shahafs@mellanox.com \
--cc=stable@dpdk.org \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).