From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <bruce.richardson@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 9F3244CAB
for <dev@dpdk.org>; Wed, 15 May 2019 13:38:56 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
15 May 2019 04:38:55 -0700
X-ExtLoop1: 1
Received: from silpixa00399126.ir.intel.com (HELO
silpixa00399126.ger.corp.intel.com) ([10.237.223.2])
by fmsmga001.fm.intel.com with ESMTP; 15 May 2019 04:38:54 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Date: Wed, 15 May 2019 12:38:47 +0100
Message-Id: <20190515113847.46380-1-bruce.richardson@intel.com>
X-Mailer: git-send-email 2.21.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson
build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 15 May 2019 11:38:57 -0000
To improve code quality we want to turn on as many warnings as we can in
the DPDK code, so turn on the "unused-parameter" warning in meson builds to
match that of the make builds. To ensure correct compilation, disable the
warning selectively for driver base code that otherwise would have issues.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 1 +
drivers/net/i40e/base/meson.build | 3 ++-
drivers/net/ice/base/meson.build | 1 +
drivers/net/ixgbe/base/meson.build | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 0d25646f5..dbdfde6b8 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c')
# enable extra warnings and disable any unwanted warnings
warning_flags = [
+ '-Wunused-parameter',
'-Wsign-compare',
'-Wcast-qual',
'-Wno-address-of-packed-member'
diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
index d4c8f872d..13d16b08d 100644
--- a/drivers/net/i40e/base/meson.build
+++ b/drivers/net/i40e/base/meson.build
@@ -13,7 +13,8 @@ sources = [
error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
'-Wno-format', '-Wno-error=format-security',
- '-Wno-strict-aliasing', '-Wno-unused-but-set-variable'
+ '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
if allow_experimental_apis
diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index 624202567..eff155574 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -16,6 +16,7 @@ sources = [
error_cflags = ['-Wno-unused-value',
'-Wno-unused-but-set-variable',
'-Wno-unused-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build
index 21ac64bf5..bbd0f51ea 100644
--- a/drivers/net/ixgbe/base/meson.build
+++ b/drivers/net/ixgbe/base/meson.build
@@ -18,7 +18,9 @@ sources = [
]
error_cflags = ['-Wno-unused-value',
- '-Wno-unused-but-set-variable']
+ '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
+ ]
c_args = cflags
if allow_experimental_apis
c_args += '-DALLOW_EXPERIMENTAL_API'
--
2.21.0
From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by dpdk.space (Postfix) with ESMTP id D702BA00E6
for <public@inbox.dpdk.org>; Wed, 15 May 2019 13:38:59 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id CED395B36;
Wed, 15 May 2019 13:38:58 +0200 (CEST)
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
by dpdk.org (Postfix) with ESMTP id 9F3244CAB
for <dev@dpdk.org>; Wed, 15 May 2019 13:38:56 +0200 (CEST)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
15 May 2019 04:38:55 -0700
X-ExtLoop1: 1
Received: from silpixa00399126.ir.intel.com (HELO
silpixa00399126.ger.corp.intel.com) ([10.237.223.2])
by fmsmga001.fm.intel.com with ESMTP; 15 May 2019 04:38:54 -0700
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Date: Wed, 15 May 2019 12:38:47 +0100
Message-Id: <20190515113847.46380-1-bruce.richardson@intel.com>
X-Mailer: git-send-email 2.21.0
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson
build
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
Message-ID: <20190515113847.SxoHeSulSwR7TgvEVgpdM1LFuv-0GW2w7URpjQGYW44@z>
To improve code quality we want to turn on as many warnings as we can in
the DPDK code, so turn on the "unused-parameter" warning in meson builds to
match that of the make builds. To ensure correct compilation, disable the
warning selectively for driver base code that otherwise would have issues.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 1 +
drivers/net/i40e/base/meson.build | 3 ++-
drivers/net/ice/base/meson.build | 1 +
drivers/net/ixgbe/base/meson.build | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 0d25646f5..dbdfde6b8 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c')
# enable extra warnings and disable any unwanted warnings
warning_flags = [
+ '-Wunused-parameter',
'-Wsign-compare',
'-Wcast-qual',
'-Wno-address-of-packed-member'
diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
index d4c8f872d..13d16b08d 100644
--- a/drivers/net/i40e/base/meson.build
+++ b/drivers/net/i40e/base/meson.build
@@ -13,7 +13,8 @@ sources = [
error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
'-Wno-format', '-Wno-error=format-security',
- '-Wno-strict-aliasing', '-Wno-unused-but-set-variable'
+ '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
if allow_experimental_apis
diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index 624202567..eff155574 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -16,6 +16,7 @@ sources = [
error_cflags = ['-Wno-unused-value',
'-Wno-unused-but-set-variable',
'-Wno-unused-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build
index 21ac64bf5..bbd0f51ea 100644
--- a/drivers/net/ixgbe/base/meson.build
+++ b/drivers/net/ixgbe/base/meson.build
@@ -18,7 +18,9 @@ sources = [
]
error_cflags = ['-Wno-unused-value',
- '-Wno-unused-but-set-variable']
+ '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
+ ]
c_args = cflags
if allow_experimental_apis
c_args += '-DALLOW_EXPERIMENTAL_API'
--
2.21.0