* [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
@ 2019-05-15 11:38 Bruce Richardson
2019-05-15 11:38 ` Bruce Richardson
2019-05-15 14:39 ` Luca Boccassi
0 siblings, 2 replies; 5+ messages in thread
From: Bruce Richardson @ 2019-05-15 11:38 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
To improve code quality we want to turn on as many warnings as we can in
the DPDK code, so turn on the "unused-parameter" warning in meson builds to
match that of the make builds. To ensure correct compilation, disable the
warning selectively for driver base code that otherwise would have issues.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 1 +
drivers/net/i40e/base/meson.build | 3 ++-
drivers/net/ice/base/meson.build | 1 +
drivers/net/ixgbe/base/meson.build | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 0d25646f5..dbdfde6b8 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c')
# enable extra warnings and disable any unwanted warnings
warning_flags = [
+ '-Wunused-parameter',
'-Wsign-compare',
'-Wcast-qual',
'-Wno-address-of-packed-member'
diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
index d4c8f872d..13d16b08d 100644
--- a/drivers/net/i40e/base/meson.build
+++ b/drivers/net/i40e/base/meson.build
@@ -13,7 +13,8 @@ sources = [
error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
'-Wno-format', '-Wno-error=format-security',
- '-Wno-strict-aliasing', '-Wno-unused-but-set-variable'
+ '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
if allow_experimental_apis
diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index 624202567..eff155574 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -16,6 +16,7 @@ sources = [
error_cflags = ['-Wno-unused-value',
'-Wno-unused-but-set-variable',
'-Wno-unused-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build
index 21ac64bf5..bbd0f51ea 100644
--- a/drivers/net/ixgbe/base/meson.build
+++ b/drivers/net/ixgbe/base/meson.build
@@ -18,7 +18,9 @@ sources = [
]
error_cflags = ['-Wno-unused-value',
- '-Wno-unused-but-set-variable']
+ '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
+ ]
c_args = cflags
if allow_experimental_apis
c_args += '-DALLOW_EXPERIMENTAL_API'
--
2.21.0
^ permalink raw reply [flat|nested] 5+ messages in thread* [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
2019-05-15 11:38 [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build Bruce Richardson
@ 2019-05-15 11:38 ` Bruce Richardson
2019-05-15 14:39 ` Luca Boccassi
1 sibling, 0 replies; 5+ messages in thread
From: Bruce Richardson @ 2019-05-15 11:38 UTC (permalink / raw)
To: dev; +Cc: Bruce Richardson
To improve code quality we want to turn on as many warnings as we can in
the DPDK code, so turn on the "unused-parameter" warning in meson builds to
match that of the make builds. To ensure correct compilation, disable the
warning selectively for driver base code that otherwise would have issues.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
config/meson.build | 1 +
drivers/net/i40e/base/meson.build | 3 ++-
drivers/net/ice/base/meson.build | 1 +
drivers/net/ixgbe/base/meson.build | 4 +++-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/config/meson.build b/config/meson.build
index 0d25646f5..dbdfde6b8 100644
--- a/config/meson.build
+++ b/config/meson.build
@@ -143,6 +143,7 @@ add_project_arguments('-include', 'rte_config.h', language: 'c')
# enable extra warnings and disable any unwanted warnings
warning_flags = [
+ '-Wunused-parameter',
'-Wsign-compare',
'-Wcast-qual',
'-Wno-address-of-packed-member'
diff --git a/drivers/net/i40e/base/meson.build b/drivers/net/i40e/base/meson.build
index d4c8f872d..13d16b08d 100644
--- a/drivers/net/i40e/base/meson.build
+++ b/drivers/net/i40e/base/meson.build
@@ -13,7 +13,8 @@ sources = [
error_cflags = ['-Wno-sign-compare', '-Wno-unused-value',
'-Wno-format', '-Wno-error=format-security',
- '-Wno-strict-aliasing', '-Wno-unused-but-set-variable'
+ '-Wno-strict-aliasing', '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
if allow_experimental_apis
diff --git a/drivers/net/ice/base/meson.build b/drivers/net/ice/base/meson.build
index 624202567..eff155574 100644
--- a/drivers/net/ice/base/meson.build
+++ b/drivers/net/ice/base/meson.build
@@ -16,6 +16,7 @@ sources = [
error_cflags = ['-Wno-unused-value',
'-Wno-unused-but-set-variable',
'-Wno-unused-variable',
+ '-Wno-unused-parameter',
]
c_args = cflags
diff --git a/drivers/net/ixgbe/base/meson.build b/drivers/net/ixgbe/base/meson.build
index 21ac64bf5..bbd0f51ea 100644
--- a/drivers/net/ixgbe/base/meson.build
+++ b/drivers/net/ixgbe/base/meson.build
@@ -18,7 +18,9 @@ sources = [
]
error_cflags = ['-Wno-unused-value',
- '-Wno-unused-but-set-variable']
+ '-Wno-unused-but-set-variable',
+ '-Wno-unused-parameter',
+ ]
c_args = cflags
if allow_experimental_apis
c_args += '-DALLOW_EXPERIMENTAL_API'
--
2.21.0
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
2019-05-15 11:38 [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build Bruce Richardson
2019-05-15 11:38 ` Bruce Richardson
@ 2019-05-15 14:39 ` Luca Boccassi
2019-05-15 14:39 ` Luca Boccassi
2019-06-03 22:07 ` Thomas Monjalon
1 sibling, 2 replies; 5+ messages in thread
From: Luca Boccassi @ 2019-05-15 14:39 UTC (permalink / raw)
To: Bruce Richardson, dev
On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> To improve code quality we want to turn on as many warnings as we can
> in
> the DPDK code, so turn on the "unused-parameter" warning in meson
> builds to
> match that of the make builds. To ensure correct compilation, disable
> the
> warning selectively for driver base code that otherwise would have
> issues.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> config/meson.build | 1 +
> drivers/net/i40e/base/meson.build | 3 ++-
> drivers/net/ice/base/meson.build | 1 +
> drivers/net/ixgbe/base/meson.build | 4 +++-
> 4 files changed, 7 insertions(+), 2 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
2019-05-15 14:39 ` Luca Boccassi
@ 2019-05-15 14:39 ` Luca Boccassi
2019-06-03 22:07 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Luca Boccassi @ 2019-05-15 14:39 UTC (permalink / raw)
To: Bruce Richardson, dev
On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> To improve code quality we want to turn on as many warnings as we can
> in
> the DPDK code, so turn on the "unused-parameter" warning in meson
> builds to
> match that of the make builds. To ensure correct compilation, disable
> the
> warning selectively for driver base code that otherwise would have
> issues.
>
> Signed-off-by: Bruce Richardson <
> bruce.richardson@intel.com
> >
> ---
> config/meson.build | 1 +
> drivers/net/i40e/base/meson.build | 3 ++-
> drivers/net/ice/base/meson.build | 1 +
> drivers/net/ixgbe/base/meson.build | 4 +++-
> 4 files changed, 7 insertions(+), 2 deletions(-)
Acked-by: Luca Boccassi <bluca@debian.org>
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build
2019-05-15 14:39 ` Luca Boccassi
2019-05-15 14:39 ` Luca Boccassi
@ 2019-06-03 22:07 ` Thomas Monjalon
1 sibling, 0 replies; 5+ messages in thread
From: Thomas Monjalon @ 2019-06-03 22:07 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Luca Boccassi
15/05/2019 16:39, Luca Boccassi:
> On Wed, 2019-05-15 at 12:38 +0100, Bruce Richardson wrote:
> > To improve code quality we want to turn on as many warnings as we can
> > in
> > the DPDK code, so turn on the "unused-parameter" warning in meson
> > builds to
> > match that of the make builds. To ensure correct compilation, disable
> > the
> > warning selectively for driver base code that otherwise would have
> > issues.
> >
> > Signed-off-by: Bruce Richardson <
> > bruce.richardson@intel.com
>
> Acked-by: Luca Boccassi <bluca@debian.org>
Applied, thanks
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-03 22:07 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-15 11:38 [dpdk-dev] [PATCH] build: add unused parameter warnings to meson build Bruce Richardson
2019-05-15 11:38 ` Bruce Richardson
2019-05-15 14:39 ` Luca Boccassi
2019-05-15 14:39 ` Luca Boccassi
2019-06-03 22:07 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).