From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 28EE45F1B for ; Wed, 15 May 2019 16:13:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 07:13:37 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga003.jf.intel.com with SMTP; 15 May 2019 07:13:34 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 May 2019 15:13:34 +0100 Date: Wed, 15 May 2019 15:13:33 +0100 From: Bruce Richardson To: David Harton Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com Message-ID: <20190515141333.GA614@bricha3-MOBL.ger.corp.intel.com> References: <20190515130512.6366-1-dharton@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515130512.6366-1-dharton@cisco.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] net/i40e: Eliminate weak symbols in i40e_rxtx.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2019 14:13:38 -0000 On Wed, May 15, 2019 at 09:05:12AM -0400, David Harton wrote: > Use of weak symbols can hide makefile errors especially when > custom makefiles are used. Removing the use of weak symbols > to avoid a stub function being linked in production code. > > Signed-off-by: David Harton > --- Looks reasonable to me. Reviewed-by: Bruce Richardson From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 00BD7A00E6 for ; Wed, 15 May 2019 16:13:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D7F65F2B; Wed, 15 May 2019 16:13:40 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 28EE45F1B for ; Wed, 15 May 2019 16:13:37 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 May 2019 07:13:37 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga003.jf.intel.com with SMTP; 15 May 2019 07:13:34 -0700 Received: by (sSMTP sendmail emulation); Wed, 15 May 2019 15:13:34 +0100 Date: Wed, 15 May 2019 15:13:33 +0100 From: Bruce Richardson To: David Harton Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com Message-ID: <20190515141333.GA614@bricha3-MOBL.ger.corp.intel.com> References: <20190515130512.6366-1-dharton@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190515130512.6366-1-dharton@cisco.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] net/i40e: Eliminate weak symbols in i40e_rxtx.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190515141333.iXekdFROguYyzMolaM28Vr-ky_MwBC4yunTD8ngGeWw@z> On Wed, May 15, 2019 at 09:05:12AM -0400, David Harton wrote: > Use of weak symbols can hide makefile errors especially when > custom makefiles are used. Removing the use of weak symbols > to avoid a stub function being linked in production code. > > Signed-off-by: David Harton > --- Looks reasonable to me. Reviewed-by: Bruce Richardson