From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr
Date: Wed, 15 May 2019 15:19:51 -0700 [thread overview]
Message-ID: <20190515221952.21959-4-stephen@networkplumber.org> (raw)
Message-ID: <20190515221951.DOuFtwPXJ6ZHaBAB3Zu_tPtVmary1gYiLhzh_3REcAQ@z> (raw)
In-Reply-To: <20190515221952.21959-1-stephen@networkplumber.org>
Use eth_unformat_addr, so that ethdev can be built and work
without the cmdline library. The dependency on cmdline was
an arrangement of convenience anyway.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/librte_ethdev/rte_class_eth.c | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c
index cb99c92ece93..40ca936230c6 100644
--- a/lib/librte_ethdev/rte_class_eth.c
+++ b/lib/librte_ethdev/rte_class_eth.c
@@ -4,7 +4,6 @@
#include <string.h>
-#include <cmdline_parse_etheraddr.h>
#include <rte_class.h>
#include <rte_compat.h>
#include <rte_errno.h>
@@ -43,19 +42,13 @@ static int
eth_mac_cmp(const char *key __rte_unused,
const char *value, void *opaque)
{
- int ret;
struct ether_addr mac;
const struct rte_eth_dev_data *data = opaque;
struct rte_eth_dev_info dev_info;
uint32_t index;
/* Parse devargs MAC address. */
- /*
- * cannot use ether_aton_r(value, &mac)
- * because of include conflict with rte_ether.h
- */
- ret = cmdline_parse_etheraddr(NULL, value, &mac, sizeof(mac));
- if (ret < 0)
+ if (ether_unformat_addr(value, &mac) < 0)
return -1; /* invalid devargs value */
/* Return 0 if devargs MAC is matching one of the device MACs. */
--
2.20.1
next prev parent reply other threads:[~2019-05-15 22:20 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 22:19 [dpdk-dev] [RFC 0/4] net/ether: improvements Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-15 22:19 ` [dpdk-dev] [RFC 1/4] net/ether: deinline non-critical functions Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 7:10 ` David Marchand
2019-05-16 7:10 ` David Marchand
2019-05-15 22:19 ` [dpdk-dev] [RFC 2/4] net/ether: add eth_unformat_addr Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 7:28 ` David Marchand
2019-05-16 7:28 ` David Marchand
2019-05-15 22:19 ` Stephen Hemminger [this message]
2019-05-15 22:19 ` [dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr Stephen Hemminger
2019-05-16 7:32 ` David Marchand
2019-05-16 7:32 ` David Marchand
2019-05-16 10:19 ` Bruce Richardson
2019-05-16 10:19 ` Bruce Richardson
2019-05-15 22:19 ` [dpdk-dev] [RFC 4/4] net/ether: use bitops to speedup comparison Stephen Hemminger
2019-05-15 22:19 ` Stephen Hemminger
2019-05-16 9:03 ` Mattias Rönnblom
2019-05-16 9:03 ` Mattias Rönnblom
2019-05-16 15:32 ` Stephen Hemminger
2019-05-16 16:03 ` Bruce Richardson
2019-05-16 16:06 ` Stephen Hemminger
2019-05-16 16:07 ` Bruce Richardson
2019-05-16 16:36 ` Bruce Richardson
2019-05-16 17:04 ` Stephen Hemminger
2019-05-16 20:37 ` Bruce Richardson
2019-05-16 20:41 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190515221952.21959-4-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).