From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 74F8BA00E6 for ; Thu, 16 May 2019 17:29:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 470AE5F33; Thu, 16 May 2019 17:29:02 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 1AA7E5F0F for ; Thu, 16 May 2019 17:29:00 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id h17so1752274pgv.0 for ; Thu, 16 May 2019 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xGwpFa7/KcsAT4dU32OTRuwkCSq57WUeaN1kyLM1Tio=; b=ZvFUXYtVxjSmoTxpnFaGl6U9MndILfFcK9UIn8jfLFkjO+lPN7m8BpYrkunw874bsa twAiReXn8LsPlZajR/5Z+tcn2E8yLl3mZPz+tUUyoacWdtNp0+qYOnmYJUiWB0CixNfU hiZknGJB348p0fCl2Lz1q+i6SPOaWoU2YRUSNFKuXcPijkYeBH+kuYk1ThK+toZZbMpM SDvpjn+44ImAZCJYQGCkTYZqzCHTHZFdWKpeBbPDN+lAJFzEl83e7VbjfuLlFo05bdLS RG9IUfTvZRVe8xwQ+jZdGD47SyHiNOwPslI/hwujf+DmKtCTingE3cQlkcEJlk4gj1S2 tZaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xGwpFa7/KcsAT4dU32OTRuwkCSq57WUeaN1kyLM1Tio=; b=BImiBzkF5TiwSGudSHgksv2qU0nPfOP8qPBwmolQ+N/HzSf8rA/z3vnuwQ0UCToNOd q29oOc/v9KK7HtuMx5MRUXxVLdHHJd4lT36YHDSiCiVkKDeZ3eEmuNVZi661hRO7ovhG FSMt8lWC66hwOM1dVnmIAiCOyYmE6DI7SsG9y2zASBI2/EuiXX/Pm+HfFCu4obWaFO40 N0aqJVFg4BZ6h6AX0Iq53IBL1fatmft0UpZ4hVc7XIc16McCtNn0T2YaJeYFe3WDsKG/ DwznHz8HCpTPxWr/1g/0TVQY3dVVRIvtn3lrpQIMSGgLa+hl7TPpSYjtl6P1oRbffaoD Kytw== X-Gm-Message-State: APjAAAUPoDsn6rGYgbzjDv+xHInW4d5cbFB97+4O3oUwqT+BJOXqBUrQ Cgu/7O1yXyG/mF9X35u8nVNBGLWBwRQ= X-Google-Smtp-Source: APXvYqxfmANhtFejx36pW3i7RfFO3cE/ufHzFQNNHiFzXOdPZsn8p0nyK46ZusXhTYdd9DWIMEuZKA== X-Received: by 2002:a63:a449:: with SMTP id c9mr15056953pgp.149.1558020539338; Thu, 16 May 2019 08:28:59 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id e12sm12758509pfl.122.2019.05.16.08.28.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 May 2019 08:28:59 -0700 (PDT) Date: Thu, 16 May 2019 08:28:57 -0700 From: Stephen Hemminger To: Jakub Grajciar Cc: Message-ID: <20190516082857.1779dec8@hermes.lan> In-Reply-To: <20190516114658.29102-1-jgrajcia@cisco.com> References: <20190513104552.27843-1-jgrajcia@cisco.com> <20190516114658.29102-1-jgrajcia@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC v8] /net: memory interface (memif) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 16 May 2019 13:46:58 +0200 Jakub Grajciar wrote: > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > index f0061d99f..b05f1462d 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -2493,6 +2493,8 @@ pmd_test_exit(void) > device = rte_eth_devices[pt_id].device; > if (device && !strcmp(device->driver->name, "net_virtio_user")) > detach_port_device(pt_id); > + else if (device && !strcmp(device->driver->name, "net_memif")) > + detach_port_device(pt_id); > } > } Why not do a proper implementation of dev_close instead of pushing the problem onto the application. The existing virtio_user hack is a bug and it should be fixed.