From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F119158EC for ; Thu, 16 May 2019 12:19:58 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 03:19:57 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga006.jf.intel.com with SMTP; 16 May 2019 03:19:55 -0700 Received: by (sSMTP sendmail emulation); Thu, 16 May 2019 11:19:54 +0100 Date: Thu, 16 May 2019 11:19:54 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190516101953.GA619@bricha3-MOBL.ger.corp.intel.com> References: <20190515221952.21959-1-stephen@networkplumber.org> <20190515221952.21959-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190515221952.21959-4-stephen@networkplumber.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 May 2019 10:19:59 -0000 On Wed, May 15, 2019 at 03:19:51PM -0700, Stephen Hemminger wrote: > Use eth_unformat_addr, so that ethdev can be built and work > without the cmdline library. The dependency on cmdline was > an arrangement of convenience anyway. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_ethdev/rte_class_eth.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > I think this patch should also modify the make and meson.build files to remove that dependency then. /Bruce From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 2167BA00E6 for ; Thu, 16 May 2019 12:20:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2515B5B12; Thu, 16 May 2019 12:20:00 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id F119158EC for ; Thu, 16 May 2019 12:19:58 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 03:19:57 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga006.jf.intel.com with SMTP; 16 May 2019 03:19:55 -0700 Received: by (sSMTP sendmail emulation); Thu, 16 May 2019 11:19:54 +0100 Date: Thu, 16 May 2019 11:19:54 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190516101953.GA619@bricha3-MOBL.ger.corp.intel.com> References: <20190515221952.21959-1-stephen@networkplumber.org> <20190515221952.21959-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Disposition: inline In-Reply-To: <20190515221952.21959-4-stephen@networkplumber.org> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [RFC 3/4] ethdev: use eth_unformat_addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190516101954.ZB6NC-LrTfbvEF4JNfs9c46Mw8TRs84MjjqYwcslmgU@z> On Wed, May 15, 2019 at 03:19:51PM -0700, Stephen Hemminger wrote: > Use eth_unformat_addr, so that ethdev can be built and work > without the cmdline library. The dependency on cmdline was > an arrangement of convenience anyway. > > Signed-off-by: Stephen Hemminger > --- > lib/librte_ethdev/rte_class_eth.c | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > I think this patch should also modify the make and meson.build files to remove that dependency then. /Bruce