From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A90ABA00E6 for ; Thu, 16 May 2019 18:08:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 74B3F5F34; Thu, 16 May 2019 18:08:09 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 2B84E5B40 for ; Thu, 16 May 2019 18:08:05 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 09:07:48 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by FMSMGA003.fm.intel.com with SMTP; 16 May 2019 09:07:46 -0700 Received: by (sSMTP sendmail emulation); Thu, 16 May 2019 17:07:45 +0100 Date: Thu, 16 May 2019 17:07:45 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: dev@dpdk.org Message-ID: <20190516160745.GB632@bricha3-MOBL.ger.corp.intel.com> References: <20190515221952.21959-1-stephen@networkplumber.org> <20190515221952.21959-5-stephen@networkplumber.org> <20190516160337.GA632@bricha3-MOBL.ger.corp.intel.com> <20190516090652.5ad965f4@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516090652.5ad965f4@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [RFC 4/4] net/ether: use bitops to speedup comparison X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 16, 2019 at 09:06:52AM -0700, Stephen Hemminger wrote: > On Thu, 16 May 2019 17:03:37 +0100 > Bruce Richardson wrote: > > > On Wed, May 15, 2019 at 03:19:52PM -0700, Stephen Hemminger wrote: > > > Using bit operations like or and xor is faster than a loop > > > on all architectures. Really just explicit unrolling. > > > > > > Similar cast to uint16 unaligned is already done in > > > other functions here. > > > > > > Signed-off-by: Stephen Hemminger > > > --- > > > lib/librte_net/rte_ether.h | 17 +++++++---------- > > > 1 file changed, 7 insertions(+), 10 deletions(-) > > > > > Rather than casting to unaligned values, which gives compiler warnings in > > some cases, I believe we should just mark the ethernet addresses as always > > being 2-byte aligned and simplify things. [unless we have a good use case > > where we won't have 2-byte alignment???]. > > > > See patch: http://patches.dpdk.org/patch/53482/ > > > > Regards, > > /Bruce > > I agree. Then you could also remove the unaligned_uint16_t that > already exists in rte_ether.h > > Do you want me to put your patch in my series? Sure, feel free. Thanks, /Bruce