From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 741C2A00E6 for ; Fri, 17 May 2019 12:21:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5AC015B1E; Fri, 17 May 2019 12:21:35 +0200 (CEST) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 48A52568A for ; Fri, 17 May 2019 12:21:33 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2019 03:21:31 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by fmsmga007.fm.intel.com with SMTP; 17 May 2019 03:21:29 -0700 Received: by (sSMTP sendmail emulation); Fri, 17 May 2019 11:21:28 +0100 Date: Fri, 17 May 2019 11:21:28 +0100 From: Bruce Richardson To: David Harton Cc: dev@dpdk.org, beilei.xing@intel.com, qi.z.zhang@intel.com Message-ID: <20190517102127.GA660@bricha3-MOBL.ger.corp.intel.com> References: <20190515161346.33080-1-dharton@cisco.com> <20190516182803.11662-1-dharton@cisco.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190516182803.11662-1-dharton@cisco.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: Eliminate weak symbols in i40e_rxtx.c X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 16, 2019 at 02:28:03PM -0400, David Harton wrote: > Use of weak symbols can hide makefile errors especially when > custom makefiles are used. Removing the use of weak symbols > to avoid a stub function being linked in production code. > > Signed-off-by: David Harton > --- > > v3 - added CONFIG_RTE_LIBRTE_I40E_INC_VECTOR to makefile > v2 - added CC_AVX2_SUPPORT check to code enabling avx2 vectors > Acked-by: Bruce Richardson