From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id 80E88A00E6
	for <public@inbox.dpdk.org>; Fri, 17 May 2019 13:11:26 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 4BA5F568A;
	Fri, 17 May 2019 13:11:25 +0200 (CEST)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id A91D72BBE
 for <dev@dpdk.org>; Fri, 17 May 2019 13:11:24 +0200 (CEST)
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com
 [10.5.11.13])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.redhat.com (Postfix) with ESMTPS id 94262811A9;
 Fri, 17 May 2019 11:11:13 +0000 (UTC)
Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 0B30B614E0;
 Fri, 17 May 2019 11:11:08 +0000 (UTC)
Date: Fri, 17 May 2019 13:11:07 +0200
From: Jens Freimann <jfreimann@redhat.com>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
 Ferruh Yigit <ferruh.yigit@intel.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <20190517111107.igbgm6xf3h3dggg4@jenstp.localdomain>
References: <1558080908-25951-1-git-send-email-david.marchand@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <1558080908-25951-1-git-send-email-david.marchand@redhat.com>
User-Agent: NeoMutt/20180716-1376-5d6ed1
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16
 (mx1.redhat.com [10.5.110.27]); Fri, 17 May 2019 11:11:18 +0000 (UTC)
Subject: Re: [dpdk-dev] [PATCH] ethdev: add a check on mempool during rxq
 setup
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, May 17, 2019 at 10:15:08AM +0200, David Marchand wrote:
>We currently have no check on the mempool pointer passed to
>rte_eth_rx_queue_setup.
>Let's avoid a plain crash when dereferencing it.
>
>Suggested-by: Jens Freimann <jfreimann@redhat.com>
>Signed-off-by: David Marchand <david.marchand@redhat.com>
>---
> lib/librte_ethdev/rte_ethdev.c | 5 +++++
> lib/librte_ethdev/rte_ethdev.h | 6 +++---
> 2 files changed, 8 insertions(+), 3 deletions(-)
>

Thanks David!

Reviewed-by: Jens Freimann <jfreimann@redhat.com>