From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 291A1A00E6 for ; Fri, 17 May 2019 13:54:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 03DC25F3C; Fri, 17 May 2019 13:54:52 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id C975F5B16; Fri, 17 May 2019 13:54:49 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 May 2019 04:54:48 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.96]) by orsmga007.jf.intel.com with SMTP; 17 May 2019 04:54:46 -0700 Received: by (sSMTP sendmail emulation); Fri, 17 May 2019 12:54:46 +0100 Date: Fri, 17 May 2019 12:54:45 +0100 From: Bruce Richardson To: dev@dpdk.org Cc: bluca@debian.org, stable@dpdk.org Message-ID: <20190517115445.GA664@bricha3-MOBL.ger.corp.intel.com> References: <20190503133537.58712-1-bruce.richardson@intel.com> <20190517114613.7027-1-bruce.richardson@intel.com> <20190517114613.7027-2-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190517114613.7027-2-bruce.richardson@intel.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v2 1/3] examples: fix install of sample apps if setting not provided X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 17, 2019 at 12:46:11PM +0100, Bruce Richardson wrote: > While the examples were being installed into the appropriate install path > when processing the examples/meson.build file, that file was only processed > if the "examples" meson parameter was non-empty. Since we now do more than > just build the examples, we need to unconditionally process the file. > > Fixes: 2daf565f91b5 ("examples: install as part of ninja install") > > Cc: stable@dpdk.org > Signed-off-by: Bruce Richardson > --- > meson.build | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/meson.build b/meson.build > index 46f9c5683..9cad43481 100644 > --- a/meson.build > +++ b/meson.build > @@ -42,10 +42,9 @@ subdir('app') > # build docs > subdir('doc') > > -# build any examples explicitly requested - useful for developers > -if get_option('examples') != '' > - subdir('examples') > -endif > +# build any examples explicitly requested - useful for developers - and > +# install any example code into the appropriate install path > +subdir('examples') > > # build kernel modules if enabled > if get_option('enable_kmods') Self-nak, sorry. Need to take account of an empty "examples" value inside examples/meson.build. V3 to follow soon. :-( /Bruce