From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 25DBFA05D3 for ; Tue, 21 May 2019 10:47:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 023DB4CAB; Tue, 21 May 2019 10:47:30 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id C65364C9D for ; Tue, 21 May 2019 10:47:28 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 01:47:27 -0700 X-ExtLoop1: 1 Received: from npg-dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.151]) by fmsmga004.fm.intel.com with ESMTP; 21 May 2019 01:47:26 -0700 Date: Tue, 21 May 2019 16:46:30 +0800 From: Tiwei Bie To: lin li Cc: dev@dpdk.org, dariusz.stojaczyk@intel.com, changpeng.liu@intel.com, Li Lin , maxime.coquelin@redhat.com Message-ID: <20190521084630.GA20965@___> References: <1556271621-8594-1-git-send-email-chuckylinchuckylin@gmail.com> <1557046942-1151-1-git-send-email-chuckylinchuckylin@gmail.com> <8ba5c1ff-08ea-6cb2-c201-b972e79da4fc@redhat.com> <20190520021310.GA11790@___> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v4] vhost: support inflight share memory protocol feature X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, May 21, 2019 at 04:29:31PM +0800, lin li wrote: > Tiwei Bie 于2019年5月20日周一上午10:14写道： > > > > On Fri, May 17, 2019 at 05:47:07PM +0200, Maxime Coquelin wrote: > > > On 5/5/19 11:02 AM, Li Lin wrote: > > [...] > > > > /** > > > > * Device structure contains all configuration information relating > > > > * to the device. > > > > @@ -303,6 +314,7 @@ struct virtio_net { > > > > uint32_t nr_vring; > > > > int dequeue_zero_copy; > > > > struct vhost_virtqueue *virtqueue[VHOST_MAX_QUEUE_PAIRS * 2]; > > > > + struct inflight_mem_info inflight_info; > > > > #define IF_NAME_SZ (PATH_MAX > IFNAMSIZ ? PATH_MAX : IFNAMSIZ) > > > > char ifname[IF_NAME_SZ]; > > > > uint64_t log_size; > > > > > > Do you have some code example using these new APIs? > > > It would help for reviewing the patch. > > > > +1 > I just submitted SPDK-related patches, and you will see how to use new API. SPDK is another separate project. For the DPDK APIs introduced in this patch, it would be great to have an example in DPDK to demonstrate their usage, e.g. examples/vhost_scsi. Besides, the new APIs also need to take the packed ring into consideration. Thanks, Tiwei