From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id D4989A05D3 for ; Wed, 22 May 2019 17:17:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A7E6B10BD; Wed, 22 May 2019 17:17:06 +0200 (CEST) Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by dpdk.org (Postfix) with ESMTP id CAD8AA69 for ; Wed, 22 May 2019 17:17:04 +0200 (CEST) Received: by mail-pg1-f193.google.com with SMTP id h17so1502316pgv.0 for ; Wed, 22 May 2019 08:17:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DlGtEj9IAqjh6x9YLfYBUvP+V/Po/+0zc7k8d2bxCqA=; b=TYUmALZ6vfQyh04rrZRJDpeiXPOWQG5k5qIzSXCl5gyYQqIRVUQFHiVq7pnj41B75w 8mMiJOgDcsxTT742AgdF1BOuBL69wsjvWLbfbXj8mSotcHKeFJKF52OJp8i08WqZFC/J CKl6wWiHP6ynqLROvalouQ1Dw+/wIXYG8po/P5jY8+1Bsz/79+s1wcjKSjIaNFbdRauq XXCMJuxByLyMVUOdfFkAElqD+Kyy1Jl0YFVnyYbmf0UpfUEXky7J/9+ghvUk5KLLkyb9 Xy4pE46jCQM/682qcOPlDtwPtMiYjoGkUGZSfy0k17SPJBuvVezSChNIbDfymhQ4FsLu YnuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DlGtEj9IAqjh6x9YLfYBUvP+V/Po/+0zc7k8d2bxCqA=; b=EL7ZX+JTDBq1Wc/pNTLg+hyC/kjw84/+2VHlf8xlAZ3wqUIJqJkyiMA1XCb7+dUy/G URiXeafkMGdKoGNcBD+YQIa4cE7KvfLbGc2kh3f1W7uuUTKN5gIrZY9YxSv1tD8OTfAj dPr6lPzWyrrVhrwrnmjQDBRSxfsDFFdpTh8if0SO0SF6hdIrEro6f/mvrhA/SI2v6gMi 3sFB41mFCDvVTPN9D9mROKNZGsltl4Op4aVHrJstMrdSPl1foefStYxdR9SBDn3LpTOk ee/v3w5bTR+qo6EkZUammQKsV081h2ffz1svJ85fhLalOf4/jF5bhVpeOIVD7gMyAHTW TNdg== X-Gm-Message-State: APjAAAUYxpjU4NnKS74rnvDY504Zw7vCGdmsoJS5CZsPQBQpIOcSYX2g JJVvcQE/1KB/2WgqCxpXgqTxIA== X-Google-Smtp-Source: APXvYqw4gJLt3zR4W+eZ6eltcoMuoI3y4h839ymOYw5OZbhjUkf3JrQLi73ZSzRzPwnZ32AEoBa21g== X-Received: by 2002:a63:1d05:: with SMTP id d5mr89989672pgd.157.1558538223956; Wed, 22 May 2019 08:17:03 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id w12sm37197254pfj.41.2019.05.22.08.17.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 22 May 2019 08:17:03 -0700 (PDT) Date: Wed, 22 May 2019 08:16:57 -0700 From: Stephen Hemminger To: Reshma Pattan Cc: dev@dpdk.org, david.hunt@intel.com, liang.j.ma@intel.com, anatoly.burakov@intel.com Message-ID: <20190522081657.52fb6e42@hermes.lan> In-Reply-To: <20190517181712.12027-1-reshma.pattan@intel.com> References: <20190517181712.12027-1-reshma.pattan@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1] examples/l3fwd-power: add telemetry mode support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 17 May 2019 19:17:12 +0100 Reshma Pattan wrote: > Add new telemetry mode support for l3fwd-power. > This is a standalone mode, in this mode l3fwd-power > does simple l3fwding along with calculating > empty polls, full polls, and busy percentage for > each forwarding core. The aggregation of these > values of all cores is reported as application > level telemetry to metric library for every 10ms from the > master core. > > The busy percentage is calculated by recording the poll_count > and when the count reaches a defined value the total > cycles it took is measured and compared with minimum and maximum > reference cycles and busy rate is set according to either 0% or > 50% or 100%. > > Signed-off-by: Reshma Pattan I think this adding more complexity to an example, which makes it harder not easier for users. The existing l3fwd-power has grown too large already and needs some architecture refactoring anyway.