From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 76706A05D3 for ; Fri, 24 May 2019 19:11:19 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B15B343C; Fri, 24 May 2019 19:11:18 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id BF9E12952 for ; Fri, 24 May 2019 19:11:16 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id f97so4424307plb.5 for ; Fri, 24 May 2019 10:11:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/lDHNPU7DkpX+MNJ4lqecloHo+/iMsP5wyymkMopiHw=; b=QZsDkQCVrC9fxAy9CP/O5UNmQ0zsNk3Q7zqDdhwg/QP4eNj1eX4VDXA1rHMc9dfsK3 vX/nvfEAVO8vA70A/MtJbmjZwLsek6mEBQJUaCkEgiH6+Hn+r5Mk6bi8WaWXV5eHvVKV wQcwglh3nxwNm5qzGLQMokFo1NDTjeyqrna5yJyQIEpXQBxi/vZyNiUIkHX6Rhoc/f/m Lh7QZboi1NjSFPxIhDpQ98KhAm1dpkZztCzsIo2eYWKpGoVn+A+kL0KPbV4cpiVrz2pD arJhD+nDAndF7zGJ0lwn5AsiEDIOYb8ztMd2z/As3kDYL/CFpIR6Uu+Nzq7YxrVyq9QB H6hA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/lDHNPU7DkpX+MNJ4lqecloHo+/iMsP5wyymkMopiHw=; b=aFs0rGbXwkW98GNMbkRVg3jrGX56KEh0/e3KbNb4Y4wrugj+7TC+XTMpfM+4M1L2K4 cYeKlKf9J+oUVHQvcHiNMG3MKr06K4GYkDL5ySaafHZqvxF9zCFTnlK+8JY4VzaBoGw0 OCl/EBOmNydX+PyX/XdVTMbR/FIZVnu/NPonU2NLLQHsWOe29i83bY8CMGHt8aN1AysC 3W4iAOXqwKBbgelV2c/vkALxd4rbMrt6gu1oVOmgVXRi2L0x0EpxnLRmGScIvbm8PnZS af2sbHU+AZBBQptMdkr287RtLB/pivv77LR/T9ske+PtVJliXGlRYcF/1DKR6hMYK5sI wM4w== X-Gm-Message-State: APjAAAVBbW5XHMeynvmDjsTe0S+2oALj3Tztli2RNs5jWkjdWKjOAXAX 3vu4+oJOneSX5TgITX52W5MjOQ== X-Google-Smtp-Source: APXvYqzL1PLBfRwYF0NVBOBmA0TRJ96AgKucA3xkXifjW5kUfL1zMdefcULnzPHF5LD9vdcDQnv1nQ== X-Received: by 2002:a17:902:e9:: with SMTP id a96mr80897926pla.37.1558717875791; Fri, 24 May 2019 10:11:15 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id o1sm8111573pfa.66.2019.05.24.10.11.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 May 2019 10:11:15 -0700 (PDT) Date: Fri, 24 May 2019 10:11:08 -0700 From: Stephen Hemminger To: Thomas Monjalon Cc: dev@dpdk.org, Ferruh Yigit , matan@mellanox.com, Stephen Hemminger Message-ID: <20190524101108.574621c8@hermes.lan> In-Reply-To: <2341346.KjBqQsXUje@xps> References: <20190523220124.18818-1-stephen@networkplumber.org> <11553980.mcJyG3iUic@xps> <20190524094812.1d4aba4c@hermes.lan> <2341346.KjBqQsXUje@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] net/vdev_netvsc: print warning if Mellanox devices are not configured X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 24 May 2019 19:05:20 +0200 Thomas Monjalon wrote: > > > > device drivers on Hyper-V/Azure. If the build system supported dependencies > > > > (like Linux kbuild) this would not be necessary. Meson only does dynamic dependencies > > > > so that doesn't help. > > > > > > > > This is a warning and not fatal only because application will still at > > > > least run, and somebody may want to run with SR-IOV with Intel NIC's on Hyper-V. > > > > > > > > > > > > The warning is just to give users better immediate feedback rather than > > > > trying to diagnose poor performance or mystery device not found messages. > > > > > > > > > It really looks strange to me. > > > What you need is to fail at compilation if requested PMD is not built. > > > I would advise to work on a script to configure meson. > > > > None of the people that ran into this were using meson build. > > For example, VPP doesn't use meson. > > They will use meson when makefile will be removed :) > > Anyway, no matter the build system, what we want is a way > to guide users to a proper DPDK installation. > Your solution is to add some very specific logs. > My proposal is to guide the user with a script and some > specific parameters so it will fail if a required dependency is not met. Not familiar enough with meson magic syntax to make vdev_netvsc not build without MLX. But that would just be pushing the mystery failure further down the road. Another alternative would be to drop vdev_netvsc from the default Linux build. That way users would have to enable it manually. My preferred solution would be to just kill vdev_netvsc and go to only netvsc PMD but that is a couple releases away.