From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 89843A045E for ; Thu, 30 May 2019 17:31:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 38880493D; Thu, 30 May 2019 17:31:50 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 67C36378B for ; Thu, 30 May 2019 17:31:49 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id go2so2698161plb.9 for ; Thu, 30 May 2019 08:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=3i5G7hm1eAXHXozgbOZODBMBR69jENgPmJz7esPCW9g=; b=aIi/TtzLh4UZ1g+TSkbtPS4aOTgh9Qp5UBNJnM2SK3Xq2+yS8SFdE1Uolk3pvmVZ9P 2lwQ3nWKvnjubGsY7xSi4Imauv8ZxO+r854Bll+4cAiYPYsl1/W+/o17JgPB3J5fXyxQ L2wEErUuWZCRGWSzMmx/vszVGgOykfDb1iP/ml9NNuOWO6S/B8Cb7HIOjN4p8DykaolG sIxOtyi6PU3l387gSA9fApLgbnau3v0MMHW/O2yg+4fejoW6CYVI+cNDi4hI4y673cfD 9otVIaJb1PcwplH3MllreQISpRRXrXUPlTz9r/X0PDYXjFU43yRApbFdFal98XN+u88M 4F2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=3i5G7hm1eAXHXozgbOZODBMBR69jENgPmJz7esPCW9g=; b=YbmCoxV5TBhrEihRpzT16UY2Aaoh3ieFBJtMtiC3CQTtYvmuYX6sOJPS+8TbEoEDc7 6XQtdn8OBZj6BVaW5wRayTCqzAR2aqGFnBd52r4TUpWdSbFrds+q+5uz4AXz+RzpkxoJ Ns9MlYvG2nWIKns/31ZS1LFbteyGlrmJ7iw/wjUhJO54WUSDHa+SCWqZU3cfTfv1NQYl yzXB8fSc1DhvqpxQperXaHe0OMtjWFmjmJPrJKdeKAzyZ4yKXq3Vs9HxDLxRVuJq6wU8 Y87cAtPayjTufNstFdM8YDIC2Szww/x4A+LcgsrSu59gYS8CGOMyqd3oAZvnUfYD9F6W SODQ== X-Gm-Message-State: APjAAAWIj9Av0B4mzL5GqP/TV1q8P6zYsOkfhGdqiAmrrNqo7Xbh2YaQ lFAiwevM+14Gc4J5aLqidmyQaA== X-Google-Smtp-Source: APXvYqzUaT0qZwKfrC4uIr/I5BH72gT6Ja98imlisxEXYj0w9n2ulCcyF20lMgUus2D/8OyxoSv4vQ== X-Received: by 2002:a17:902:8303:: with SMTP id bd3mr4265536plb.240.1559230308360; Thu, 30 May 2019 08:31:48 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id q4sm2676903pgb.39.2019.05.30.08.31.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 30 May 2019 08:31:48 -0700 (PDT) Date: Thu, 30 May 2019 08:31:44 -0700 From: Stephen Hemminger To: Xiaolong Ye Cc: Qi Zhang , John McNamara , Marko Kovacevic , Karlsson Magnus , Topel Bjorn , dev@dpdk.org Message-ID: <20190530083144.4b785ba5@hermes.lan> In-Reply-To: <20190530090707.36290-2-xiaolong.ye@intel.com> References: <20190515083842.15116-1-xiaolong.ye@intel.com> <20190530090707.36290-1-xiaolong.ye@intel.com> <20190530090707.36290-2-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/af_xdp: enable zero copy by extbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 30 May 2019 17:07:05 +0800 Xiaolong Ye wrote: > Implement zero copy of af_xdp pmd through mbuf's external memory > mechanism to achieve high performance. > > This patch also provides a new parameter "pmd_zero_copy" for user, so they > can choose to enable zero copy of af_xdp pmd or not. > > To be clear, "zero copy" here is different from the "zero copy mode" of > AF_XDP, it is about zero copy between af_xdp umem and mbuf used in dpdk > application. > > Suggested-by: Varghese Vipin > Suggested-by: Tummala Sivaprasad > Suggested-by: Olivier Matz > Signed-off-by: Xiaolong Ye Why is this a parameter? Can it just be auto detected. Remember configuration is evil, it hurts usability, code coverage and increases complexity.