From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id B9DFBA045E for ; Fri, 31 May 2019 03:57:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 20444378B; Fri, 31 May 2019 03:57:48 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 8E00D375B for ; Fri, 31 May 2019 03:57:46 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 May 2019 18:57:45 -0700 X-ExtLoop1: 1 Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga004.fm.intel.com with ESMTP; 30 May 2019 18:57:44 -0700 Date: Fri, 31 May 2019 09:49:13 +0800 From: Ye Xiaolong To: Stephen Hemminger Cc: Qi Zhang , John McNamara , Marko Kovacevic , Karlsson Magnus , Topel Bjorn , Ananyev Konstantin , dev@dpdk.org Message-ID: <20190531014913.GA42839@intel.com> References: <20190515083842.15116-1-xiaolong.ye@intel.com> <20190530090707.36290-1-xiaolong.ye@intel.com> <20190530090707.36290-2-xiaolong.ye@intel.com> <20190530083144.4b785ba5@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530083144.4b785ba5@hermes.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2 1/3] net/af_xdp: enable zero copy by extbuf X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 05/30, Stephen Hemminger wrote: >On Thu, 30 May 2019 17:07:05 +0800 >Xiaolong Ye wrote: > >> Implement zero copy of af_xdp pmd through mbuf's external memory >> mechanism to achieve high performance. >> >> This patch also provides a new parameter "pmd_zero_copy" for user, so they >> can choose to enable zero copy of af_xdp pmd or not. >> >> To be clear, "zero copy" here is different from the "zero copy mode" of >> AF_XDP, it is about zero copy between af_xdp umem and mbuf used in dpdk >> application. >> >> Suggested-by: Varghese Vipin >> Suggested-by: Tummala Sivaprasad >> Suggested-by: Olivier Matz >> Signed-off-by: Xiaolong Ye > >Why is this a parameter? Can it just be auto detected. In case there might be situations when some users would perfer a slower copy mode, we can just let user decide. Thanks, Xiaolong >Remember configuration is evil, it hurts usability, code coverage >and increases complexity.