From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 80FBEA0096 for ; Tue, 4 Jun 2019 12:01:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC2C81BBDD; Tue, 4 Jun 2019 12:01:47 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 0BEB81BBD7 for ; Tue, 4 Jun 2019 12:01:45 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 03:01:44 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga005.jf.intel.com with SMTP; 04 Jun 2019 03:01:42 -0700 Received: by (sSMTP sendmail emulation); Tue, 04 Jun 2019 11:01:42 +0100 Date: Tue, 4 Jun 2019 11:01:41 +0100 From: Bruce Richardson To: Loc Nguyen Cc: thomas@monjalon.net, dev@dpdk.org Message-ID: <20190604100141.GA1311@bricha3-MOBL.ger.corp.intel.com> References: <20190603125736.48511-1-locnguyen@niometrics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603125736.48511-1-locnguyen@niometrics.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] usertools: add device index for dpdk-devbind script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 03, 2019 at 08:57:36PM +0800, Loc Nguyen wrote: > Add a device index in front of the PCI ID for easy counting > > Network devices using DPDK-compatible driver > ============================================ > 0: 0000:07:00.0 ... > 1: 0000:07:00.1 ... > > Signed-off-by: Loc Nguyen > --- > usertools/dpdk-devbind.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > While I don't see anything wrong with this change, can you elaborate on why you think this is of use? The rest of the script doesn't do anything with these indexes so why is it worth using columns of screen space to display them? Thanks, /Bruce