* [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524)
@ 2019-06-03 13:50 Artur Trybula
2019-06-04 9:05 ` Mcnamara, John
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 0/1] app/test-compress-perf: fix reliance on integer endianness Artur Trybula
0 siblings, 2 replies; 6+ messages in thread
From: Artur Trybula @ 2019-06-03 13:50 UTC (permalink / raw)
To: dev, fiona.trahe, arturx.trybula, adamx.dybkowski
This patch fixes Coverity Issue 328524:
Reliance on integer endianness (INCOMPATIBLE_CAST) in function *parse_window_sz*.
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
index 2fb6fb48a..a7a8c1f9e 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -364,12 +364,14 @@ parse_max_num_sgl_segs(struct comp_test_data *test_data, const char *arg)
static int
parse_window_sz(struct comp_test_data *test_data, const char *arg)
{
- int ret = parse_uint16_t((uint16_t *)&test_data->window_sz, arg);
+ uint16_t tmp;
+ int ret = parse_uint16_t(&tmp, arg);
if (ret) {
RTE_LOG(ERR, USER1, "Failed to parse window size\n");
return -1;
}
+ test_data->window_sz = (int)tmp;
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524)
2019-06-03 13:50 [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524) Artur Trybula
@ 2019-06-04 9:05 ` Mcnamara, John
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 0/1] app/test-compress-perf: fix reliance on integer endianness Artur Trybula
1 sibling, 0 replies; 6+ messages in thread
From: Mcnamara, John @ 2019-06-04 9:05 UTC (permalink / raw)
To: Trybula, ArturX, dev, Trahe, Fiona, Trybula, ArturX, Dybkowski, AdamX
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Artur Trybula
> Sent: Monday, June 3, 2019 2:51 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; Trybula, ArturX
> <arturx.trybula@intel.com>; Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on
> integer endianness (CI:328524)
>
> This patch fixes Coverity Issue 328524:
> Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> *parse_window_sz*.
This patch should have a fixes line. The usual message would include:
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Coverity issue: 328524
John
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-dev] [PATCH v2 0/1] app/test-compress-perf: fix reliance on integer endianness
2019-06-03 13:50 [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524) Artur Trybula
2019-06-04 9:05 ` Mcnamara, John
@ 2019-06-04 12:41 ` Artur Trybula
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 1/1] " Artur Trybula
1 sibling, 1 reply; 6+ messages in thread
From: Artur Trybula @ 2019-06-04 12:41 UTC (permalink / raw)
To: dev, fiona.trahe, adamx.dybkowski, arturx.trybula
v2:
* add 'fixes' line to the patch description
Artur Trybula (1):
app/test-compress-perf: fix reliance on integer endianness (CI:328524)
app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on integer endianness
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 0/1] app/test-compress-perf: fix reliance on integer endianness Artur Trybula
@ 2019-06-04 12:41 ` Artur Trybula
2019-06-26 17:06 ` Shally Verma
0 siblings, 1 reply; 6+ messages in thread
From: Artur Trybula @ 2019-06-04 12:41 UTC (permalink / raw)
To: dev, fiona.trahe, adamx.dybkowski, arturx.trybula
This patch fixes Coverity Issue 328524:
Reliance on integer endianness (INCOMPATIBLE_CAST) in function
*parse_window_sz*.
Coverity issue: 328524
Fixes: e0b6287c035d ("app/compress-perf: add parser")
Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
---
app/test-compress-perf/comp_perf_options_parse.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/app/test-compress-perf/comp_perf_options_parse.c b/app/test-compress-perf/comp_perf_options_parse.c
index 2fb6fb48a..a7a8c1f9e 100644
--- a/app/test-compress-perf/comp_perf_options_parse.c
+++ b/app/test-compress-perf/comp_perf_options_parse.c
@@ -364,12 +364,14 @@ parse_max_num_sgl_segs(struct comp_test_data *test_data, const char *arg)
static int
parse_window_sz(struct comp_test_data *test_data, const char *arg)
{
- int ret = parse_uint16_t((uint16_t *)&test_data->window_sz, arg);
+ uint16_t tmp;
+ int ret = parse_uint16_t(&tmp, arg);
if (ret) {
RTE_LOG(ERR, USER1, "Failed to parse window size\n");
return -1;
}
+ test_data->window_sz = (int)tmp;
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on integer endianness
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 1/1] " Artur Trybula
@ 2019-06-26 17:06 ` Shally Verma
2019-07-01 11:37 ` Akhil Goyal
0 siblings, 1 reply; 6+ messages in thread
From: Shally Verma @ 2019-06-26 17:06 UTC (permalink / raw)
To: Artur Trybula, dev, fiona.trahe, adamx.dybkowski
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Artur Trybula
> Sent: Tuesday, June 4, 2019 6:11 PM
> To: dev@dpdk.org; fiona.trahe@intel.com; adamx.dybkowski@intel.com;
> arturx.trybula@intel.com
> Subject: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on
> integer endianness
>
> This patch fixes Coverity Issue 328524:
> Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> *parse_window_sz*.
>
> Coverity issue: 328524
> Fixes: e0b6287c035d ("app/compress-perf: add parser")
>
> Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> ---
Acked-by: Shally Verma <shallyv@marvell.com>
Shally
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-dev] [PATCH v2 1/1] app/test-compress-perf: fix reliance on integer endianness
2019-06-26 17:06 ` Shally Verma
@ 2019-07-01 11:37 ` Akhil Goyal
0 siblings, 0 replies; 6+ messages in thread
From: Akhil Goyal @ 2019-07-01 11:37 UTC (permalink / raw)
To: Shally Verma, Artur Trybula, dev, fiona.trahe, adamx.dybkowski
> >
> > This patch fixes Coverity Issue 328524:
> > Reliance on integer endianness (INCOMPATIBLE_CAST) in function
> > *parse_window_sz*.
> >
> > Coverity issue: 328524
> > Fixes: e0b6287c035d ("app/compress-perf: add parser")
> >
> > Signed-off-by: Artur Trybula <arturx.trybula@intel.com>
> > ---
> Acked-by: Shally Verma <shallyv@marvell.com>
>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-01 11:37 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 13:50 [dpdk-dev] [PATCH] app/test-compress-perf: fix reliance on integer endianness (CI:328524) Artur Trybula
2019-06-04 9:05 ` Mcnamara, John
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 0/1] app/test-compress-perf: fix reliance on integer endianness Artur Trybula
2019-06-04 12:41 ` [dpdk-dev] [PATCH v2 1/1] " Artur Trybula
2019-06-26 17:06 ` Shally Verma
2019-07-01 11:37 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).