From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id C3DC7A0096 for ; Wed, 5 Jun 2019 08:58:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B088A1B945; Wed, 5 Jun 2019 08:58:04 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id A70615398; Wed, 5 Jun 2019 08:58:02 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Jun 2019 23:58:01 -0700 X-ExtLoop1: 1 Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga001.fm.intel.com with ESMTP; 04 Jun 2019 23:58:00 -0700 Date: Wed, 5 Jun 2019 14:49:10 +0800 From: Ye Xiaolong To: David Marchand Cc: Ferruh Yigit , dev , dpdk stable Message-ID: <20190605064910.GA111340@intel.com> References: <20190604163147.105791-1-xiaolong.ye@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/05, David Marchand wrote: >Hello, > >On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye wrote: > >> Fixes: af75078fece3 ("first public release") >> Cc: stable@dpdk.org >> >> Signed-off-by: Xiaolong Ye >> --- >> lib/librte_eal/linux/eal/eal.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lib/librte_eal/linux/eal/eal.c >> b/lib/librte_eal/linux/eal/eal.c >> index 161399619..10e2887ca 100644 >> --- a/lib/librte_eal/linux/eal/eal.c >> +++ b/lib/librte_eal/linux/eal/eal.c >> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv) >> } >> >> if (rte_eal_alarm_init() < 0) { >> - rte_eal_init_alert("Cannot init interrupt-handling >> thread"); >> + rte_eal_init_alert("Cannot init alarm"); >> /* rte_eal_alarm_init sets rte_errno on failure. */ >> return -1; >> } >> -- >> 2.17.1 >> >> >The same applies to freebsd eal. > >lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) { >lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot >init interrupt-handling thread"); Er, yes, do I need to make another separate patch or just add the freebsd fix into this patch? Thanks, Xiaolong > > >-- >David Marchand