DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, dev <dev@dpdk.org>,
	dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm
Date: Wed, 5 Jun 2019 15:12:51 +0800	[thread overview]
Message-ID: <20190605071251.GB111340@intel.com> (raw)
In-Reply-To: <CAJFAV8y2_miU2VKJBmsW1JJoRH3BzFrapOkY5UXY6RJERCy=Cw@mail.gmail.com>

On 06/05, David Marchand wrote:
>On Wed, Jun 5, 2019 at 8:58 AM Ye Xiaolong <xiaolong.ye@intel.com> wrote:
>
>> On 06/05, David Marchand wrote:
>> >Hello,
>> >
>> >On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye <xiaolong.ye@intel.com> wrote:
>> >
>> >> Fixes: af75078fece3 ("first public release")
>> >> Cc: stable@dpdk.org
>> >>
>> >> Signed-off-by: Xiaolong Ye <xiaolong.ye@intel.com>
>> >> ---
>> >>  lib/librte_eal/linux/eal/eal.c | 2 +-
>> >>  1 file changed, 1 insertion(+), 1 deletion(-)
>> >>
>> >> diff --git a/lib/librte_eal/linux/eal/eal.c
>> >> b/lib/librte_eal/linux/eal/eal.c
>> >> index 161399619..10e2887ca 100644
>> >> --- a/lib/librte_eal/linux/eal/eal.c
>> >> +++ b/lib/librte_eal/linux/eal/eal.c
>> >> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv)
>> >>         }
>> >>
>> >>         if (rte_eal_alarm_init() < 0) {
>> >> -               rte_eal_init_alert("Cannot init interrupt-handling
>> >> thread");
>> >> +               rte_eal_init_alert("Cannot init alarm");
>> >>                 /* rte_eal_alarm_init sets rte_errno on failure. */
>> >>                 return -1;
>> >>         }
>> >> --
>> >> 2.17.1
>> >>
>> >>
>> >The same applies to freebsd eal.
>> >
>> >lib/librte_eal/freebsd/eal/eal.c:       if (rte_eal_alarm_init() < 0) {
>> >lib/librte_eal/freebsd/eal/eal.c-               rte_eal_init_alert("Cannot
>> >init interrupt-handling thread");
>>
>> Er, yes, do I need to make another separate patch or just add the freebsd
>> fix
>> into this patch?
>>
>
>$ git fixline 764bf268
>Fixes: 764bf26873b9 ("add FreeBSD support")
>$ git describe --contains 764bf268
>v1.6.0r0~58
>
>Both fixes are old enough to be relevant to the same stable branches (if we
>want to backport this), so you can add it to this patch yes.
>

Agree, will squash freebsd fix into this patch and send v2.

Thanks,
Xiaolong
>
>-- 
>David Marchand

  reply	other threads:[~2019-06-05  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-04 16:31 [dpdk-dev] " Xiaolong Ye
2019-06-05  6:51 ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-06-05  6:49   ` Ye Xiaolong
2019-06-05  7:13     ` David Marchand
2019-06-05  7:12       ` Ye Xiaolong [this message]
2019-06-05  7:18 ` [dpdk-dev] [PATCH v2] " Xiaolong Ye
2019-06-05  7:31   ` David Marchand
2019-06-27 15:02     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605071251.GB111340@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).