From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7BBF7A0096 for ; Wed, 5 Jun 2019 09:21:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CA4CA1B94B; Wed, 5 Jun 2019 09:21:45 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D56322C0C; Wed, 5 Jun 2019 09:21:43 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Jun 2019 00:21:42 -0700 X-ExtLoop1: 1 Received: from yexl-server.sh.intel.com (HELO localhost) ([10.67.110.206]) by fmsmga006.fm.intel.com with ESMTP; 05 Jun 2019 00:21:41 -0700 Date: Wed, 5 Jun 2019 15:12:51 +0800 From: Ye Xiaolong To: David Marchand Cc: Ferruh Yigit , dev , dpdk stable Message-ID: <20190605071251.GB111340@intel.com> References: <20190604163147.105791-1-xiaolong.ye@intel.com> <20190605064910.GA111340@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: correct error log for alarm X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 06/05, David Marchand wrote: >On Wed, Jun 5, 2019 at 8:58 AM Ye Xiaolong wrote: > >> On 06/05, David Marchand wrote: >> >Hello, >> > >> >On Tue, Jun 4, 2019 at 6:41 PM Xiaolong Ye wrote: >> > >> >> Fixes: af75078fece3 ("first public release") >> >> Cc: stable@dpdk.org >> >> >> >> Signed-off-by: Xiaolong Ye >> >> --- >> >> lib/librte_eal/linux/eal/eal.c | 2 +- >> >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> >> >> diff --git a/lib/librte_eal/linux/eal/eal.c >> >> b/lib/librte_eal/linux/eal/eal.c >> >> index 161399619..10e2887ca 100644 >> >> --- a/lib/librte_eal/linux/eal/eal.c >> >> +++ b/lib/librte_eal/linux/eal/eal.c >> >> @@ -1006,7 +1006,7 @@ rte_eal_init(int argc, char **argv) >> >> } >> >> >> >> if (rte_eal_alarm_init() < 0) { >> >> - rte_eal_init_alert("Cannot init interrupt-handling >> >> thread"); >> >> + rte_eal_init_alert("Cannot init alarm"); >> >> /* rte_eal_alarm_init sets rte_errno on failure. */ >> >> return -1; >> >> } >> >> -- >> >> 2.17.1 >> >> >> >> >> >The same applies to freebsd eal. >> > >> >lib/librte_eal/freebsd/eal/eal.c: if (rte_eal_alarm_init() < 0) { >> >lib/librte_eal/freebsd/eal/eal.c- rte_eal_init_alert("Cannot >> >init interrupt-handling thread"); >> >> Er, yes, do I need to make another separate patch or just add the freebsd >> fix >> into this patch? >> > >$ git fixline 764bf268 >Fixes: 764bf26873b9 ("add FreeBSD support") >$ git describe --contains 764bf268 >v1.6.0r0~58 > >Both fixes are old enough to be relevant to the same stable branches (if we >want to backport this), so you can add it to this patch yes. > Agree, will squash freebsd fix into this patch and send v2. Thanks, Xiaolong > >-- >David Marchand