From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7D180A0096 for ; Wed, 5 Jun 2019 17:02:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 152F31BB20; Wed, 5 Jun 2019 17:02:10 +0200 (CEST) Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by dpdk.org (Postfix) with ESMTP id 7FC461BAE4 for ; Wed, 5 Jun 2019 17:02:08 +0200 (CEST) Received: by mail-pl1-f193.google.com with SMTP id a93so219732pla.7 for ; Wed, 05 Jun 2019 08:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dA0UArRrsU5+xk0Nt7h6jyBPFuHyvGEX0ZvLB0Ynrt8=; b=olIJs8RDoy+182XlPDjN5SE9h341G9lECX7t1HH0+fRB607mbV5USNaym/OyhS8cTG wdaazPQ6DrGxbPYXMlxK64SWR5j8apxnipBzysUN76+zHViKC0rY97Rw22MGYbnL1SWM MUirCHwmhJBI2++cRH5IJ9GsDK+JBYC2+0aL55vbLuuSDoIgZ2ILfagMm3l9Mfk8X9U5 inbCmMQHB+X31GfAsOaKb6mwzBIJwQ8+KvMMmcx7N5mPZt82ZcI2pQ6WpeehxVSDV+pl kaYpWt+aaV7E4klPlSSCMTnFUl1IsnPQfxmu7wjkRLB5q3q4U53Me969/bmtOQ0MyQJG PLBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dA0UArRrsU5+xk0Nt7h6jyBPFuHyvGEX0ZvLB0Ynrt8=; b=a3LO4nBPCl2ZDaVX8oMW3a5841InSDj8Ukq9R3gUDTKUQ62ezm2AFjqTy35XfjSHfU a7GA9bBfO8BvaoJx3aCs2u63U48H9+KNQfDRzeLp0SI+QEYdZbLjcp0yy1W0OGH6Bqo8 UnAk8238zvvgawe3KcKgjtp8OgGVLJHcZRj4LDZDv0GhIHsiUcu8A3D4CA1OQYbBIZxV cbZg3555JPtJki9R9xrYgy34LfLv9f9pEiJBvr5kkdu3IajaFTSmvlbiOIfUkF5ptYA1 m+4hYfZ4+dtKWisMJ3OEcLXrTsE8FTirl0xCHQePr7k4rjhve6a5BxUUy3ykMxhHPSi/ WYcQ== X-Gm-Message-State: APjAAAVtHvSbiFlIMk1D0FHnrnEv8olqXLisoFemFBp2dnLrSGs3kgN3 pGPH4lCZfn+JqUnodBkNk6zIkA== X-Google-Smtp-Source: APXvYqxB+rBeLwobbJYdQtJse+brFiYTyOxnfi31kXElpU4KUEAk/0uqiV7ptg+hdTRmLyFYaW6MGQ== X-Received: by 2002:a17:902:a505:: with SMTP id s5mr42113026plq.54.1559746927407; Wed, 05 Jun 2019 08:02:07 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id k22sm10470252pfk.178.2019.06.05.08.02.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 05 Jun 2019 08:02:07 -0700 (PDT) Date: Wed, 5 Jun 2019 08:02:05 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: Message-ID: <20190605080205.711a9bbc@hermes.lan> In-Reply-To: References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605010852.28395-1-stephen@networkplumber.org> <20190605010852.28395-4-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/6] ethdev: use rte_eth_unformat_addr X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 5 Jun 2019 11:59:52 +0300 Andrew Rybchenko wrote: > On 6/5/19 4:08 AM, Stephen Hemminger wrote: > > Use rte_eth_unformat_addr, so that ethdev can be built and work > > without the cmdline library. The dependency on cmdline was > > an arrangement of convenience anyway. > > > > Signed-off-by: Stephen Hemminger > > [...] > > > diff --git a/lib/librte_ethdev/rte_class_eth.c b/lib/librte_ethdev/rte_class_eth.c > > index 873a653532ad..6338355e2557 100644 > > --- a/lib/librte_ethdev/rte_class_eth.c > > +++ b/lib/librte_ethdev/rte_class_eth.c > > @@ -4,7 +4,6 @@ > > > > #include > > > > -#include > > #include > > #include > > #include > > @@ -43,19 +42,13 @@ static int > > eth_mac_cmp(const char *key __rte_unused, > > const char *value, void *opaque) > > { > > - int ret; > > struct rte_ether_addr mac; > > const struct rte_eth_dev_data *data = opaque; > > struct rte_eth_dev_info dev_info; > > uint32_t index; > > > > /* Parse devargs MAC address. */ > > - /* > > - * cannot use ether_aton_r(value, &mac) > > - * because of include conflict with rte_ether.h > > Why not ether_aton_r()? Isn't conflict resolved now after patch series > from Olivier? > I think it would be nice to explain it in the changeset description. ether_aton_r won;t work for 3 three ushorts model.