From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id A0A3EA0096 for ; Wed, 5 Jun 2019 20:10:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8A4011B9D5; Wed, 5 Jun 2019 20:10:04 +0200 (CEST) Received: from mail-pf1-f193.google.com (mail-pf1-f193.google.com [209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 706431B9BB for ; Wed, 5 Jun 2019 20:09:59 +0200 (CEST) Received: by mail-pf1-f193.google.com with SMTP id a186so14590394pfa.5 for ; Wed, 05 Jun 2019 11:09:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5jmpHlnhidg0ShQ7XItCpgaXpVK1xXtowoDpbYktXUk=; b=XadfSMOizEdSDgaqiHAT8iH8ENYyMvZq9NMxBxgaSUglWCR6SJXOPL1HlXsgzeGPZo hyfc3q0SGOz10hsHveX/mhh3O0J8I2qZ8wzgf5viQ0Rs0oLagYn+0kalRiKyh5cfVuAz URkZjTcdvEwqHuxH3FF9Vo+4dom2pxikDbdMxo96likOdphKWMDjNlhtgIvxpC6Ls7TV KzvH2j/xFF46zt34GUVSihEYA/GUgZb4ud9ko6AWhAi43QtnHtjZH6WfmG9XC+Ht0FE2 QmRz9n3WBog3SnNKyWXWQtVtEtjjUO67cLh2QWZnP4UBRSHL2DYLuwlBdMlP7kRpkZ12 fMmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5jmpHlnhidg0ShQ7XItCpgaXpVK1xXtowoDpbYktXUk=; b=DtA5zx3mtx3hhqVuowUkT+61TBIcJpOtE8rZo04Mh+I9eH5zt7i6Rs5pPqe8HBXjP4 s/nyNjHK+DOs26vd+aP2KzkFG/PcLfGqGwWoUuCZqwWvTdwFLRrMqL7tWBJ/NsO6C84i uVaGSlFCSLulODChk8yD145p5EB/IRwLeAV16eDgwJRzoyt8iGTn8lzq7boajohfrWHu QNeYEGmOT8wtjbKrkXz6Mkw2203LZxsBLrcjxq/S/G+o7/FBqfCs8pPJIbtKNdWdGASD v8k75iyPWtNSpppdkb1O6GXHmkcuzhzfwQIr7cLkrJIw91cWyHwRc4gDnhCb3IcbjQId fWBQ== X-Gm-Message-State: APjAAAW6WuuJDYpMtER2l04povpZ+hOUrXy/lNG/rhh3NwYxZV5Axf+M hG1h5tLwkKXdJXpEP0WlRUYkU6N5Ndo= X-Google-Smtp-Source: APXvYqzxxeHi2d1blocFiU2ylXXXz4WW9B8hZLOlUzGHqdTPkqVToSYmcyoKdFQjPdS1DdlxeHb+Bg== X-Received: by 2002:a63:c744:: with SMTP id v4mr6290398pgg.370.1559758197893; Wed, 05 Jun 2019 11:09:57 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a7sm19081888pgj.42.2019.06.05.11.09.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 11:09:57 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Bruce Richardson , Stephen Hemminger , Andrew Rybchenko Date: Wed, 5 Jun 2019 11:09:45 -0700 Message-Id: <20190605180948.22414-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190605180948.22414-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605180948.22414-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 5/8] net/ether: mark ethernet addresses as being 2-byte aligned X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Bruce Richardson When including the rte_ether.h header in applications with warnings enabled, a warning was given because of the assumption of 2-byte alignment of ethernet addresses when processing them. .../include/rte_ether.h:149:2: warning: converting a packed ‘const struct ether_addr’ pointer (alignment 1) to a ‘unaligned_uint16_t’ {aka ‘const short unsigned int’} pointer (alignment 2) may result in an unaligned pointer value [-Waddress-of-packed-member] 149 | const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; | ^~~~~ Since ethernet addresses should always be aligned on a two-byte boundary, we can just inform the compiler of this assumption to remove the warnings and allow us to always access the addresses using 16-bit operations. Signed-off-by: Bruce Richardson Signed-off-by: Stephen Hemminger Reviewed-by: Andrew Rybchenko --- lib/librte_net/rte_ether.h | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index feb35a33c94b..d7b76ddf63eb 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -58,7 +58,8 @@ extern "C" { * See http://standards.ieee.org/regauth/groupmac/tutorial.html */ struct rte_ether_addr { - uint8_t addr_bytes[RTE_ETHER_ADDR_LEN]; /**< Addr bytes in tx order */ + uint8_t addr_bytes[RTE_ETHER_ADDR_LEN] __rte_aligned(2); + /**< Addr bytes in tx order */ } __attribute__((__packed__)); #define RTE_ETHER_LOCAL_ADMIN_ADDR 0x02 /**< Locally assigned Eth. address. */ @@ -81,8 +82,8 @@ struct rte_ether_addr { static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, const struct rte_ether_addr *ea2) { - const unaligned_uint16_t *w1 = (const uint16_t *)ea1; - const unaligned_uint16_t *w2 = (const uint16_t *)ea2; + const uint16_t *w1 = (const uint16_t *)ea1; + const uint16_t *w2 = (const uint16_t *)ea2; return ((w1[0] ^ w2[0]) | (w1[1] ^ w2[1]) | (w1[2] ^ w2[2])) == 0; } @@ -99,7 +100,7 @@ static inline int rte_is_same_ether_addr(const struct rte_ether_addr *ea1, */ static inline int rte_is_zero_ether_addr(const struct rte_ether_addr *ea) { - const unaligned_uint16_t *w = (const uint16_t *)ea; + const uint16_t *w = (const uint16_t *)ea; return (w[0] | w[1] | w[2]) == 0; } @@ -146,7 +147,7 @@ static inline int rte_is_multicast_ether_addr(const struct rte_ether_addr *ea) */ static inline int rte_is_broadcast_ether_addr(const struct rte_ether_addr *ea) { - const unaligned_uint16_t *ea_words = (const unaligned_uint16_t *)ea; + const uint16_t *ea_words = (const uint16_t *)ea; return (ea_words[0] == 0xFFFF && ea_words[1] == 0xFFFF && ea_words[2] == 0xFFFF); -- 2.20.1