From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id ABF17A0096 for ; Wed, 5 Jun 2019 20:11:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B553F1B9E5; Wed, 5 Jun 2019 20:10:07 +0200 (CEST) Received: from mail-pl1-f194.google.com (mail-pl1-f194.google.com [209.85.214.194]) by dpdk.org (Postfix) with ESMTP id 0E5181B9C8 for ; Wed, 5 Jun 2019 20:10:02 +0200 (CEST) Received: by mail-pl1-f194.google.com with SMTP id g9so9978245plm.6 for ; Wed, 05 Jun 2019 11:10:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=ogndnz/zRfgrUUIHW0MA9aQ9C17XBMreWgHh/U/vmnkvk7BrvAwK6/dULtuYA21zzN mng8gZsPkzxzYX2X8X+cJpTCzANGPp4TdBEmQUmdnoynyK1jVQH6Rve3GwGMTS9TauF6 +Tw4e7+Xazxq7Ebz6TUjIJeuT/G0brKkZ6eneh1aVSOMi8noi3pfQBJEA0c/RYY6+vFc 6LZCm2Muf6otC3oPVPxzWvmAIOx9RCOd6Tbwg6ofKjqGUbl5VkrLP1pwEpAmfi64fauP FYqpfJpiRquz+klNGttcMkJmUg9UeP5BIXI+Se0nwCxy6496BOY32uTSvoFoyK60iE4O d8uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=i8sEf2BqVxRRW7Hf5r4EMIM/xDPKtZVL0Pik8O21io8=; b=og2oy4H6b/TzebMIUwLXQznizmOMeCs/Astzjfd/4/hqE1wItB35Py7o8RYCa5EvEo NPD7JGiOJeNrBZITlz1aedhgV3REx34VTW74/a3WRtqrS+8eSHUf4m+zpVJtyo2soMTB mmhFYDBZTZ5hp2jJ+bTrdMBCEYoCREAzwbD2AonOdYm+A6X6X3x9ZjDUqtjJER//fmNi MFZ/UxNmhoOwAmzAmbinHPNWTSxyenhJnwtU6cmmApP3YUmRqQhTyWz+Kd8O90/kpF/+ Kz7RHKaszOp2ySG6uhRCzO+7MsYNuyPLAJJQJxR2Qv1JdlMIMZ7vH4YsyAiS9DEe+CU/ aGWQ== X-Gm-Message-State: APjAAAWL+DRd3KMgPrMMHg+0oNex+Rh+dkrll67FR7lP6ZgKux7uUe+o 262Hfdae3oO03XX1KPkV8cWRdV9OKBw= X-Google-Smtp-Source: APXvYqy2PqdtlYLod5xjnb7ToBAI5fUc8cCdp81UVksD/RDMx3fhcwySIPQJhb50wXlZc+Ctf/iT7Q== X-Received: by 2002:a17:902:aa0a:: with SMTP id be10mr38353191plb.27.1559758200962; Wed, 05 Jun 2019 11:10:00 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id a7sm19081888pgj.42.2019.06.05.11.09.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Jun 2019 11:09:59 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Date: Wed, 5 Jun 2019 11:09:47 -0700 Message-Id: <20190605180948.22414-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190605180948.22414-1-stephen@networkplumber.org> References: <20190516180427.17270-1-stephen@networkplumber.org> <20190605180948.22414-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 7/8] net/bonding: use rte_ether_unformat_addr rather than cmdline_parse X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The cmdline library used to be the only way to parse a mac address. Now there is rte_ether_unformat_addr. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/Makefile | 2 +- drivers/net/bonding/meson.build | 2 +- drivers/net/bonding/rte_eth_bond_args.c | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/net/bonding/Makefile b/drivers/net/bonding/Makefile index 1893e3cad313..26c1782554cd 100644 --- a/drivers/net/bonding/Makefile +++ b/drivers/net/bonding/Makefile @@ -12,7 +12,7 @@ CFLAGS += -DALLOW_EXPERIMENTAL_API CFLAGS += -O3 CFLAGS += $(WERROR_FLAGS) LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring -LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs -lrte_cmdline +LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_pci -lrte_bus_pci LDLIBS += -lrte_bus_vdev diff --git a/drivers/net/bonding/meson.build b/drivers/net/bonding/meson.build index 00374edb2a9d..6267210adf5f 100644 --- a/drivers/net/bonding/meson.build +++ b/drivers/net/bonding/meson.build @@ -8,6 +8,6 @@ sources = files('rte_eth_bond_api.c', 'rte_eth_bond_pmd.c', 'rte_eth_bond_flow.c 'rte_eth_bond_args.c', 'rte_eth_bond_8023ad.c', 'rte_eth_bond_alb.c') deps += 'sched' # needed for rte_bitmap.h -deps += ['ip_frag', 'cmdline'] +deps += ['ip_frag'] install_headers('rte_eth_bond.h', 'rte_eth_bond_8023ad.h') diff --git a/drivers/net/bonding/rte_eth_bond_args.c b/drivers/net/bonding/rte_eth_bond_args.c index 01bbb06c1a84..936440fb8491 100644 --- a/drivers/net/bonding/rte_eth_bond_args.c +++ b/drivers/net/bonding/rte_eth_bond_args.c @@ -7,9 +7,6 @@ #include #include -#include -#include - #include "rte_eth_bond.h" #include "rte_eth_bond_private.h" @@ -281,8 +278,7 @@ bond_ethdev_parse_bond_mac_addr_kvarg(const char *key __rte_unused, return -1; /* Parse MAC */ - return cmdline_parse_etheraddr(NULL, value, extra_args, - sizeof(struct rte_ether_addr)); + return rte_ether_unformat_addr(value, extra_args); } int -- 2.20.1