From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 01094A0096 for ; Thu, 6 Jun 2019 21:49:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B2BF45424; Thu, 6 Jun 2019 21:49:33 +0200 (CEST) Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by dpdk.org (Postfix) with ESMTP id 9507A4C8B for ; Thu, 6 Jun 2019 21:49:32 +0200 (CEST) Received: by mail-pl1-f195.google.com with SMTP id g21so1340318plq.0 for ; Thu, 06 Jun 2019 12:49:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=keYpJvumHazCaDqHctyt2sALyIDOH1dfrGTITJVfRec=; b=q5avFwaSZaZOFbzKgM6FKAh1TredME8n+/QfsnKtuYgBjovYCz44B01/ytXXMy2Rvm bp0uOeXlXNC/KytaVtnLSeBUsGIa2okQAvuBR+ZAXsLQvHVWDc9caB5WvCnAxfFfj73g FJ9C7wzsIAhwX3LYg3Zdd6S/oNMccy1Lzq6y5cuoDMMUl+zE9r34FVPv3WA9a4XyCLFo PE/98WfHUwbx1+XIub62Uwh07bzRF5/FfsYqhGsgj+0euDxeh+s/DdOQlA2IFTve3u28 YHMEohkJmjCCYpu4MJnY/5kSjLdzBx4Lvc0zsysA1UzU0ofBSs420+/3JEJa5+7BDQu3 swPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=keYpJvumHazCaDqHctyt2sALyIDOH1dfrGTITJVfRec=; b=qbNGWBPGbUBeb6bdYqAFjvfoAe3ualtqH74yIPEymjFwuloUdb0Z3V3z4+M0fD5zNU IjrbhwG3J/fqQPRrq6UQ2suNNdMJRriaS0vPtyfiAgt1aAojxgdCYNye2H9Hwvb31u+J 6UYAyLG1d6Kh3ihu7/A+y3WEkyhJUydMEr0d7IX+HnZCoK2m1CHhQjEu3FU+Pla21Uyg 6BE7+ri4ExNkDx7jGcV4rgmN7tgqPR0h5gOp/sZI9zrJLduyBZTQP+YvSArYwMf+5tl8 90snvjim1uITfGgkKHsOEoc9vlVjBzT5+gKikFqJ3j7OkrBrH4n24YerQSxS3WUIeQY3 6Htw== X-Gm-Message-State: APjAAAXXJrXSzPSIuX2Yo8ZIqbjV+Oxx6G+eRyYb8m0lbXLZu9VoOtns wiEbLLNn86kZXwGkjPTTompqiA== X-Google-Smtp-Source: APXvYqz7YoZPFXVo73IrC2rBUqBISOgCsjCePxKOcrYDAPUB0x8SZw3X1aenwcjDhCXIEX8Nci3caw== X-Received: by 2002:a17:902:b58f:: with SMTP id a15mr51490506pls.201.1559850571696; Thu, 06 Jun 2019 12:49:31 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id x14sm2983182pfq.158.2019.06.06.12.49.31 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 06 Jun 2019 12:49:31 -0700 (PDT) Date: Thu, 6 Jun 2019 12:49:27 -0700 From: Stephen Hemminger To: Vipin Varghese Cc: olivier.matz@6wind.com, reshma.pattan@intel.com, keith.wiles@intel.com, dev@dpdk.org, sanjay.padubidri@intel.com Message-ID: <20190606124927.1a369d5b@hermes.lan> In-Reply-To: <20190606183355.56734-1-vipin.varghese@intel.com> References: <20190606183355.56734-1-vipin.varghese@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 7 Jun 2019 00:03:54 +0530 Vipin Varghese wrote: > Add callback event handler for enqueue dequeue operation on ring. > The pre-enqueue and post-dequeue operation on ring is selected to > invoke user callback handler. > > Signed-off-by: Vipin Varghese > --- NAK What is the use case for this? Rings are one of the most used elements of DPDK and anything like this will have performance impact. And as DPDK goes to more of distribution model, all features have to be enabled. Also, this looks like a problem: +struct rte_ring_callback { + TAILQ_ENTRY(rte_ring_callback) next; /* Callbacks list */ + rte_ring_cb_fn cb_fn; /* Callback address */ + void *cb_arg; /* Parameter for callback */ + uint32_t active; /* Callback is executing */ The active element is likely updated in one thread and queried in another it needs to be volatile, or better yet an atomic to ensure memory ordering.