[dpdk-dev] [PATCH] net/netvsc: initialize vf spinlock

[dpdk-dev] [PATCH] net/netvsc: initialize vf spinlock

[Stephen Hemminger]

The VF spinlock was never initialized. It works because it is
in zmalloc'd memory and an unlocked lock on x86 is 0.
But for good practice, all spinlock's should be initialized.

Fixes: dc7680e8597c ("net/netvsc: support integrated VF")
Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>
---
 drivers/net/netvsc/hn_ethdev.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c
index 9e7cf2df5472..70352f0e1a3d 100644
--- a/drivers/net/netvsc/hn_ethdev.c
+++ b/drivers/net/netvsc/hn_ethdev.c
@@ -739,6 +739,7 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev)
 	hv->port_id = eth_dev->data->port_id;
 	hv->latency = HN_CHAN_LATENCY_NS;
 	hv->max_queues = 1;
+	rte_spinlock_init(&hv->vf_lock);
 	hv->vf_port = HN_INVALID_PORT;
 
 	err = hn_parse_args(eth_dev);
-- 
2.20.1

Re: [dpdk-dev] [PATCH] net/netvsc: initialize vf spinlock

[Ferruh Yigit]

On 6/6/2019 5:15 PM, Stephen Hemminger wrote:
> The VF spinlock was never initialized. It works because it is
> in zmalloc'd memory and an unlocked lock on x86 is 0.
> But for good practice, all spinlock's should be initialized.
> 
> Fixes: dc7680e8597c ("net/netvsc: support integrated VF")
> Signed-off-by: Stephen Hemminger <sthemmin@microsoft.com>

Applied to dpdk-next-net/master, thanks.