From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DE462A0096 for ; Thu, 6 Jun 2019 18:15:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7F0D1B95B; Thu, 6 Jun 2019 18:15:15 +0200 (CEST) Received: from mail-pl1-f196.google.com (mail-pl1-f196.google.com [209.85.214.196]) by dpdk.org (Postfix) with ESMTP id 1510C1B959 for ; Thu, 6 Jun 2019 18:15:14 +0200 (CEST) Received: by mail-pl1-f196.google.com with SMTP id s24so1113536plr.8 for ; Thu, 06 Jun 2019 09:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=27TFo36/GxBEbpGFt1EcK+h9MHdQ+F3HDzXS6EUm118=; b=fEW83SRdlwa0IX3Og0RbPLzUV+xHy1qKR661AEHiwtr/NaUM0w9JSn3/ozs2VLF3PQ UDtbdZ1bMN43ot5YpH6O4kQQPaJJDSu/gKN+oeRJ/VqOTaoUytTwtjPqVzual32Ewp8z PX/Jvg4jAzcoj2VRG3IW1zqcyhpUOB0vptUcUoq3rV3idL4f0V1Ldy81LMFIOAuKOfr9 R/ZTAeUcsmaM4ftE+ruR+L0A6+G4mR3nMGgUOuxn3RwZU/vUYmLy1C5df8nwRGRXFxD7 9uMuSuJw0qTkmGiYcboPr85KWEffzEaghe7YVyT5tRQgIu19Z5sbMIVxeCc+e3t8ziSz yK1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=27TFo36/GxBEbpGFt1EcK+h9MHdQ+F3HDzXS6EUm118=; b=JmsaNrWf3aLv6ZVP7Ea2EE4Ssplb0mggPLBR0yXuM6jBkBVSc7AD5v2gqSZ84jYjcG xSWxxHa0Mlh1E7Hmn81payjqILSsI+gjhVi9asoYXzNfEtc0+GcBJZt6ioAmDTlUdldP azV8NDm5KSnZVWnd5FIWsHc7eaoXNEotQWYzxKlUcARzI3mwPludZa5UqJ4UuJ7+Cn55 bwvuzdzDEANS4wFF9c0gSQDhg7MIkBMAqNapcJOxBw65tWW/MVay77F0kJ1QL0/ZG4Be l1WWoKb4ttLysYb3VFExfqzSzAL59j5YRh7OUuzng0OI2xrDmqHKQqovwPEr9ibzHJgs kkxg== X-Gm-Message-State: APjAAAWxDdTPoBseP+3lCKZ3jaZOBs3hvYcHiUqdWAf1pz0IV+pK5vu8 3fC7m66TKWMarfxc6fLiqme9tl41jr0= X-Google-Smtp-Source: APXvYqz8VpQT3AEn5zDYiDtyOH2koWFIL+6Az/xVtAn8X5sBWUTYlzJha0Dub6+EctrR28cue5pA1w== X-Received: by 2002:a17:902:6b44:: with SMTP id g4mr35228530plt.35.1559837712811; Thu, 06 Jun 2019 09:15:12 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id t25sm2056679pgv.30.2019.06.06.09.15.11 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 06 Jun 2019 09:15:11 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Stephen Hemminger Date: Thu, 6 Jun 2019 09:15:10 -0700 Message-Id: <20190606161510.8211-1-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] net/netvsc: initialize vf spinlock X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The VF spinlock was never initialized. It works because it is in zmalloc'd memory and an unlocked lock on x86 is 0. But for good practice, all spinlock's should be initialized. Fixes: dc7680e8597c ("net/netvsc: support integrated VF") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 9e7cf2df5472..70352f0e1a3d 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -739,6 +739,7 @@ eth_hn_dev_init(struct rte_eth_dev *eth_dev) hv->port_id = eth_dev->data->port_id; hv->latency = HN_CHAN_LATENCY_NS; hv->max_queues = 1; + rte_spinlock_init(&hv->vf_lock); hv->vf_port = HN_INVALID_PORT; err = hn_parse_args(eth_dev); -- 2.20.1