From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 98107A0096 for ; Fri, 7 Jun 2019 11:30:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 660161B965; Fri, 7 Jun 2019 11:30:49 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id DDF9A1B958 for ; Fri, 7 Jun 2019 11:30:47 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Jun 2019 02:30:46 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga007.jf.intel.com with SMTP; 07 Jun 2019 02:30:42 -0700 Received: by (sSMTP sendmail emulation); Fri, 07 Jun 2019 10:30:42 +0100 Date: Fri, 7 Jun 2019 10:30:42 +0100 From: Bruce Richardson To: Stephen Hemminger Cc: Vipin Varghese , olivier.matz@6wind.com, reshma.pattan@intel.com, keith.wiles@intel.com, dev@dpdk.org, sanjay.padubidri@intel.com Message-ID: <20190607093042.GB1600@bricha3-MOBL.ger.corp.intel.com> References: <20190606183355.56734-1-vipin.varghese@intel.com> <20190606124927.1a369d5b@hermes.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190606124927.1a369d5b@hermes.lan> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH v1 1/2] lib/ring: add enqueue-dequeue callabck X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 06, 2019 at 12:49:27PM -0700, Stephen Hemminger wrote: > On Fri, 7 Jun 2019 00:03:54 +0530 > Vipin Varghese wrote: > > > Add callback event handler for enqueue dequeue operation on ring. > > The pre-enqueue and post-dequeue operation on ring is selected to > > invoke user callback handler. > > > > Signed-off-by: Vipin Varghese > > --- > > NAK > What is the use case for this? Rings are one of the most used elements > of DPDK and anything like this will have performance impact. > > And as DPDK goes to more of distribution model, all features have to be > enabled. > To add callback handlers to a ring, I'd suggest wrapping the ring as an ethdev using the ring pmd, and then using the ethdev callbacks. /Bruce