From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 192EAA0096 for ; Fri, 7 Jun 2019 14:18:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 273321BB6F; Fri, 7 Jun 2019 14:18:29 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id BF6C11B9DE for ; Fri, 7 Jun 2019 14:18:27 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id v14so1950667wrr.4 for ; Fri, 07 Jun 2019 05:18:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=5jeeeH/igNfjheL5senXX9u80JNGbEmSAaPPWP/ZFis=; b=V9F1q2A5gzMUQ2cKE7dcD+gJAwLbqUKDzZ8hde7WnEriMvZck4YcwD9wOVOwmHXMDa C8ifPyZlFR/FBrJCUBQ6XIHVDGlWyBBQJvtAJoVrjirlfp3L/0tlyPtdlHI0vPcqn9Df n5Wg8gwgS37wVmDyVeOfdvBCuubebbAEIUs7z4iAgw7anL6Ncag6qYjs9Ivet3tNh8u5 cJQ3M5C8cgbIltRtEUDR97+dHna252hn7HrSCeZC3nPFWZ+JUGC0UCZlkN1NA2Bjcway rb0iT5iFgrrpYaCWu+x5HeZ2UAqcxlE01h8QsMRTE81t7/E5jDx7f0kRxDI0Rm3TPwF4 ODzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=5jeeeH/igNfjheL5senXX9u80JNGbEmSAaPPWP/ZFis=; b=d0R14Y8h2IoLn7/CHhM476p4GnAJNxNCPt1H0/6b8wbFsGAqK76YHGV/ts+plFPDub OmORrUj4fDvBOlihqJbOwmr5MKGzzbAarhulYGlZlMJDd5/L2g4+q55FqW3/RvhrtMWi A+k7SRzL1gl69oEGfbgVNTIT2gpLl28bB0RhIjUUE+KJy15rPx2dBqgr63UrwAL5ir3t xgIrzk6TKPFPzFoYIRYFdUhwwCEae1Iv89Oj4U3qGBScHtfi0+4cmuCmP9Lmr2gWYWWn OP+4S1emMjb4gLf6duzMdO0UiXig3F4RdPiqbR90Ic3y2tDn97o3w+cgF27Y3B1Juu+q EjDQ== X-Gm-Message-State: APjAAAWxs2P2LFe7CfLDXvm3n7i9WwyF1Fi9An3EQqjhETnEfgZF81Ec YSxAkziTSI0izUNj2ravhd3a7w== X-Google-Smtp-Source: APXvYqzab3tf2vxvpVjlIy33n77P00/w488re7nNRox0sZbdNvqMPzTNC4ShYSo94vqwCU4GY9EemA== X-Received: by 2002:adf:ef0a:: with SMTP id e10mr18274767wro.303.1559909907344; Fri, 07 Jun 2019 05:18:27 -0700 (PDT) Received: from bidouze.vm.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z5sm1694104wmf.48.2019.06.07.05.18.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 07 Jun 2019 05:18:26 -0700 (PDT) Date: Fri, 7 Jun 2019 14:18:24 +0200 From: =?iso-8859-1?Q?Ga=EBtan?= Rivet To: Ferruh Yigit Cc: Stephen Hemminger , dev@dpdk.org, Stephen Hemminger Message-ID: <20190607121824.wpsqlffw4ghezsia@bidouze.vm.6wind.com> References: <20190516035310.31145-1-stephen@networkplumber.org> <296f3374-cd02-c758-674e-1e61f84d0c3c@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <296f3374-cd02-c758-674e-1e61f84d0c3c@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH] net/failsafe: fix reported device info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 07, 2019 at 11:58:27AM +0100, Ferruh Yigit wrote: > On 5/16/2019 4:53 AM, Stephen Hemminger wrote: > > The failsafe driver device info had several issues in the > > info it reported in dev_info_get: > > - it cleared dev_info->device set in rte_eth_dev_info_get > > - many fields (for example max_rx_queue) should be the minimum > > of all sub devices > > - it reported tx capa for the active transmit device, but > > the device may change. > > > > There was enough messed up that ended up reworking the info_get > > handler. There is no need to save current values or have a > > template for defaults. > > > > Fixes: 4e31ee26ed51 ("net/failsafe: report actual device capabilities") > > Signed-off-by: Stephen Hemminger > > Hi Gaetan, > > Reminder of this patch waiting for your review. > > Thanks, > ferruh > Hi Ferruh, Thanks for the reminder, Acked-by: Gaetan Rivet -- Gaëtan Rivet 6WIND