From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 13AD9A0495 for ; Mon, 10 Jun 2019 11:37:24 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5829E1BFAD; Mon, 10 Jun 2019 11:37:23 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 99EB51BF59 for ; Mon, 10 Jun 2019 11:37:21 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jun 2019 02:37:20 -0700 X-ExtLoop1: 1 Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga001.jf.intel.com with SMTP; 10 Jun 2019 02:37:18 -0700 Received: by (sSMTP sendmail emulation); Mon, 10 Jun 2019 10:37:17 +0100 Date: Mon, 10 Jun 2019 10:37:17 +0100 From: Bruce Richardson To: Igor Ryzhov Cc: dev@dpdk.org Message-ID: <20190610093717.GA1925@bricha3-MOBL.ger.corp.intel.com> References: <20190610082552.79083-1-iryzhov@nfware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610082552.79083-1-iryzhov@nfware.com> User-Agent: Mutt/1.11.4 (2019-03-13) Subject: Re: [dpdk-dev] [PATCH] kernel/linux: fix modules install path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 10, 2019 at 11:25:52AM +0300, Igor Ryzhov wrote: > Currently kernel modules are installed into /usr/src/ instead of > /lib/modules when meson build system is used. This patch fixes that. > > Old build option "kernel_dir" is changed to "kernel_version". > > Signed-off-by: Igor Ryzhov > --- > kernel/linux/igb_uio/meson.build | 2 +- > kernel/linux/kni/meson.build | 2 +- > kernel/linux/meson.build | 16 +++++++++------- > meson_options.txt | 4 ++-- > 4 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/kernel/linux/igb_uio/meson.build b/kernel/linux/igb_uio/meson.build > index f5a9d5ccf..5093610e3 100644 > --- a/kernel/linux/igb_uio/meson.build > +++ b/kernel/linux/igb_uio/meson.build > @@ -16,5 +16,5 @@ custom_target('igb_uio', > 'modules'], > depends: mkfile, > install: true, > - install_dir: kernel_dir + '/../extra/dpdk', > + install_dir: kernel_install_dir + '/extra/dpdk', > build_by_default: get_option('enable_kmods')) > diff --git a/kernel/linux/kni/meson.build b/kernel/linux/kni/meson.build > index a9f48b0e6..8a902d2ed 100644 > --- a/kernel/linux/kni/meson.build > +++ b/kernel/linux/kni/meson.build > @@ -25,5 +25,5 @@ custom_target('rte_kni', > depends: kni_mkfile, > console: true, > install: true, > - install_dir: kernel_dir + '/../extra/dpdk', > + install_dir: kernel_install_dir + '/extra/dpdk', > build_by_default: get_option('enable_kmods')) > diff --git a/kernel/linux/meson.build b/kernel/linux/meson.build > index a37c95752..5a9303b33 100644 > --- a/kernel/linux/meson.build > +++ b/kernel/linux/meson.build > @@ -3,19 +3,21 @@ > > subdirs = ['igb_uio', 'kni'] > > -# if we are cross-compiling we need kernel_dir specified > -if get_option('kernel_dir') == '' and meson.is_cross_build() > - warning('Need "kernel_dir" option for kmod compilation when cross-compiling') > +# if we are cross-compiling we need kernel_version specified > +if get_option('kernel_version') == '' and meson.is_cross_build() > + warning('Need "kernel_version" option for kmod compilation when cross-compiling') > subdir_done() > endif Looking at the patch now, I'm not sure that this change from kernel_dir to kernel_version is the right thing to do - since it almost certainly cause issues for cross-compiling. The kernel modules almost certainly won't be in the host's /lib/modules folder in cross-compile cases, so I think we need to continue to specify a path to the kernel modules folder. To me the simplest option is that we should take the path to the kernels module folder i.e. same as now, just without the "/build". A comment update in the meson_options.txt file should be all that is needed to modify that parameter, and we should be able to have the meson.build file automatically strip "/build" off the path in order to enable backward compatibility. What do you think? /Bruce