From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 91D58A00E6 for ; Mon, 10 Jun 2019 19:52:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 632951C137; Mon, 10 Jun 2019 19:52:03 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 68C201C0C5 for ; Mon, 10 Jun 2019 19:52:00 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id a3so5431394pgb.3 for ; Mon, 10 Jun 2019 10:52:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=X1yVQGqrZQ8ggLucTFmm4o9ozoX09oUCiOVVwP9qWrKSyJulDbaeenJ3WK1d7UhYHZ Bdp1WLXhnj2eK3irGeZGtXeQ9n5eLyEMMhsREl96ennHaMOFP4XXSfUmyHKYdEClSpD+ 6e0/Dyb1enVYpt3ktnO7olbQ/DR2yHhwEwyQ8uh+H/b5c4te2L91MWynnZUeeJBZk26q SnSLvrbugQYPpmKA0nEFg0+vvqk0l1nEVi99a7NExIWq+dkVWzxhKNSv2VhHq7UjPFts KPDx4+1IXPpJzMfM27+tgXA/VRLQDC0caSMrp1RpC5mGvRVG5YFSquTlozZBn4zuvFan ehSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=lx7mNNtKZOJfi54i/SUlINrC4myA0zQHh+IpidBgz5c=; b=rldxsX3utU7ikoOh6uZLxwUCZW3Fz1/4X9uVuuCxXZ6mErmoQqYrqfI7NrPxrXt3zB 5SNm6LNf+pdbqo86waYCytNWfhz0VGAucJNbaK2BRkZNmzr6+pEH984oEh092ECjhKWE gwKPVO/aZZY27DVqJLKeX4xLej5DwKUZdqApTdRaEhDNZV6Uv3RcIrEqQ+Du0KNP3Xd8 DnOgRajj6DuVJ5MfBtCfi75XdG/0rcl9BXls2c9ErJKbszGFjqioRY/AnAiSa5t/ymof zhvrgZO0xM2ANjILbGsQVwT8f/ZND+kwkzg5/F5h+4qO1xxno+qBGUgx/OVW56w3xjxp YosQ== X-Gm-Message-State: APjAAAUCK6yjTRzLiZYxnEmuylRXhYpdK2tTUIK+dr+8kj09KYmf5VEG vbEcOZef3yAqs8BBTQWHrpr0Lg== X-Google-Smtp-Source: APXvYqyJP6i5LxGEo4q895TB0mjMugPG01ieUJGJ+RPApich82qCl8bBZRIiotUXRWRSq/UKEWHlzQ== X-Received: by 2002:a65:6210:: with SMTP id d16mr15158335pgv.180.1560189119528; Mon, 10 Jun 2019 10:51:59 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id l38sm131656pje.12.2019.06.10.10.51.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 10 Jun 2019 10:51:58 -0700 (PDT) From: Stephen Hemminger To: ferruh.yigit@intel.com Cc: dev@dpdk.org, Stephen Hemminger Date: Mon, 10 Jun 2019 10:51:49 -0700 Message-Id: <20190610175155.21374-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190610175155.21374-1-stephen@networkplumber.org> References: <20190610175155.21374-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 1/7] kni: don't need stubs for rx_mode or ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The netdev subsystem already handles case where network sevice does not support ioctl. If device has no rx_mode hook it is not called. Signed-off-by: Stephen Hemminger --- kernel/linux/kni/kni_net.c | 19 ------------------- 1 file changed, 19 deletions(-) diff --git a/kernel/linux/kni/kni_net.c b/kernel/linux/kni/kni_net.c index ad8365877cda..c86337d099ab 100644 --- a/kernel/linux/kni/kni_net.c +++ b/kernel/linux/kni/kni_net.c @@ -593,23 +593,6 @@ kni_net_tx_timeout(struct net_device *dev) netif_wake_queue(dev); } -/* - * Ioctl commands - */ -static int -kni_net_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) -{ - pr_debug("kni_net_ioctl group:%d cmd:%d\n", - ((struct kni_dev *)netdev_priv(dev))->group_id, cmd); - - return -EOPNOTSUPP; -} - -static void -kni_net_set_rx_mode(struct net_device *dev) -{ -} - static int kni_net_change_mtu(struct net_device *dev, int new_mtu) { @@ -758,8 +741,6 @@ static const struct net_device_ops kni_net_netdev_ops = { .ndo_change_rx_flags = kni_net_set_promiscusity, .ndo_start_xmit = kni_net_tx, .ndo_change_mtu = kni_net_change_mtu, - .ndo_do_ioctl = kni_net_ioctl, - .ndo_set_rx_mode = kni_net_set_rx_mode, .ndo_get_stats = kni_net_stats, .ndo_tx_timeout = kni_net_tx_timeout, .ndo_set_mac_address = kni_net_set_mac, -- 2.20.1